From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 1/6] ide: set IDE_AFLAG_DRQ_INTERRUPT in do_identify() Date: Fri, 22 Aug 2008 14:20:40 +0400 Message-ID: <48AE92F8.8020704@ru.mvista.com> References: <20080819183934.16469.69799.sendpatchset@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from h155.mvista.com ([63.81.120.155]:15915 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754695AbYHVKUq (ORCPT ); Fri, 22 Aug 2008 06:20:46 -0400 In-Reply-To: <20080819183934.16469.69799.sendpatchset@localhost.localdomain> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, Borislav Petkov , linux-kernel@vger.kernel.org Hello. Bartlomiej Zolnierkiewicz wrote: > Set IDE_AFLAG_DRQ_INTERRUPT in do_identify() instead of ATAPI > device drivers *_setup() methods. > > While at it: > - use ata_id_cdb_intr() > > There should be no functional changes caused by this patch. > > Cc: Borislav Petkov > Signed-off-by: Bartlomiej Zolnierkiewicz > [...] > Index: b/drivers/ide/ide-cd.c > =================================================================== > --- a/drivers/ide/ide-cd.c > +++ b/drivers/ide/ide-cd.c > @@ -1887,9 +1887,6 @@ static int ide_cdrom_setup(ide_drive_t * > drive->atapi_flags = IDE_AFLAG_MEDIA_CHANGED | IDE_AFLAG_NO_EJECT | > ide_cd_flags(id); > > - if ((id[ATA_ID_CONFIG] & 0x0060) == 0x20) > - drive->atapi_flags |= IDE_AFLAG_DRQ_INTERRUPT; > - > Wait, this needs to be fixed first -- 0x20 does *not* mean CDB INTRQ! > Index: b/drivers/scsi/ide-scsi.c > =================================================================== > --- a/drivers/scsi/ide-scsi.c > +++ b/drivers/scsi/ide-scsi.c > @@ -385,8 +385,6 @@ static const struct ide_proc_devset ides > */ > static void idescsi_setup (ide_drive_t *drive, idescsi_scsi_t *scsi) > { > - if ((drive->id[ATA_ID_CONFIG] & 0x0060) == 0x20) > This one is wrong too... WBR, Sergei