From: Tejun Heo <htejun@gmail.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
linux-ide@vger.kernel.org, Thomas Renninger <trenn@suse.de>,
Robert Hancock <hancockr@shaw.ca>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Regression: SATA disk double spin-off during hibernation on hp nx6325
Date: Fri, 29 Aug 2008 12:42:14 +0200 [thread overview]
Message-ID: <48B7D286.7050104@gmail.com> (raw)
In-Reply-To: <200808291241.04183.rjw@sisk.pl>
Rafael J. Wysocki wrote:
> Actaully, they do belong to it. This is the part "fixing" the hibernation code
> path, in which the disk is also powered off unnecessarily.
>
> Well, probably I should use SYSTEM_HIBERNATE_ENTER or something similar
> instead of SYSTEM_SUSPEND_DISK.
>
> In short, the idea is to change system_state to something specific to the last
> phase of hibernation (after saving the image) and check that in
> ata_scsi_start_stop_xlat(). In fact that's completely analogous to what's done
> for SYSTEM_POWER_OFF in there.
Ah.. right, missed the added check for SUSPEND_DISK in libata-scsi.c.
Maybe it's a good idea to note it in the commit message later?
Thanks.
--
tejun
next prev parent reply other threads:[~2008-08-29 10:43 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-28 22:02 Regression: SATA disk double spin-off during hibernation on hp nx6325 Rafael J. Wysocki
2008-08-29 10:03 ` Tejun Heo
2008-08-29 10:41 ` Rafael J. Wysocki
2008-08-29 10:42 ` Tejun Heo [this message]
2008-09-06 17:23 ` [PATCH] SATA: Blacklist systems that spin off disks during ACPI power off Rafael J. Wysocki
2008-09-08 11:38 ` Tejun Heo
2008-09-14 2:21 ` Jeff Garzik
2008-09-15 0:00 ` Rafael J. Wysocki
2008-09-17 21:50 ` Jeff Garzik
2008-09-29 22:06 ` [PATCH 0/6] " Rafael J. Wysocki
2008-09-29 22:10 ` [PATCH 1/6] Hibernation: Introduce new system state for the last phase of hibernation Rafael J. Wysocki
2008-10-01 3:32 ` Tejun Heo
2008-10-01 11:36 ` Rafael J. Wysocki
2008-10-03 8:35 ` Andrew Morton
2008-10-03 11:27 ` Rafael J. Wysocki
2008-10-03 12:43 ` Andrew Morton
2008-10-03 15:03 ` Rafael J. Wysocki
2008-10-03 21:48 ` [PATCH 0/6] SATA: Blacklist systems that spin off disks during ACPI power off (rev. 2) Rafael J. Wysocki
2008-10-03 21:51 ` [PATCH 1/6] Hibernation: Introduce system_entering_hibernation Rafael J. Wysocki
2008-10-03 23:27 ` Alan Cox
2008-10-04 10:13 ` Rafael J. Wysocki
2008-10-04 21:50 ` Alan Cox
2008-10-04 21:52 ` Tejun Heo
2008-10-04 22:30 ` Rafael J. Wysocki
2008-10-04 22:27 ` Tejun Heo
2008-10-04 7:02 ` Tejun Heo
2008-10-04 10:14 ` Rafael J. Wysocki
2008-10-03 21:52 ` [PATCH 2/6] DMI: Introduce dmi_first_match to make the interface more flexible Rafael J. Wysocki
2008-10-03 21:57 ` [PATCH 3/6] SATA: Blacklisting of systems that spin off disks during ACPI power off (rev. 2) Rafael J. Wysocki
2008-10-03 21:57 ` [PATCH 4/6] SATA AHCI: Blacklist system that spins off disks during ACPI power off Rafael J. Wysocki
2008-10-03 21:58 ` [PATCH 5/6] SATA Sil: " Rafael J. Wysocki
2008-10-03 21:58 ` [PATCH 6/6] SATA PIIX: " Rafael J. Wysocki
2008-10-03 12:49 ` [PATCH 1/6] Hibernation: Introduce new system state for the last phase of hibernation Arjan van de Ven
2008-10-03 15:05 ` Rafael J. Wysocki
2008-09-29 22:13 ` [PATCH 2/6] DMI: Introduce dmi_first_match to make the interface more flexible Rafael J. Wysocki
2008-10-01 3:31 ` Tejun Heo
2008-09-29 22:14 ` [PATCH 3/6] SATA: Blacklisting of systems that spin off disks during ACPI power off Rafael J. Wysocki
2008-10-01 3:34 ` Tejun Heo
2008-10-01 11:36 ` Rafael J. Wysocki
2008-09-29 22:15 ` [PATCH 4/6] SATA AHCI: Blacklist system that spins " Rafael J. Wysocki
2008-09-29 22:16 ` [PATCH 5/6] SATA Sil: " Rafael J. Wysocki
2008-09-29 22:18 ` [PATCH 6/6] SATA PIIX: " Rafael J. Wysocki
[not found] ` <200808291245.27436.elendil@planet.nl>
2008-08-29 10:57 ` Regression: SATA disk double spin-off during hibernation on hp nx6325 Rafael J. Wysocki
2008-08-29 11:30 ` Frans Pop
2008-09-04 14:05 ` Rafael J. Wysocki
2008-09-05 22:25 ` Frans Pop
2008-09-05 23:18 ` Rafael J. Wysocki
2008-09-06 0:09 ` Frans Pop
2008-09-06 11:06 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B7D286.7050104@gmail.com \
--to=htejun@gmail.com \
--cc=hancockr@shaw.ca \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).