* [PATCH #upstream-fixes] libata-sff: kill spurious WARN_ON() in ata_hsm_move()
@ 2008-08-29 14:27 Tejun Heo
2008-09-08 16:16 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2008-08-29 14:27 UTC (permalink / raw)
To: Jeff Garzik, IDE/ATA development list
On HSM_ST_ERR, ata_hsm_move() triggers WARN_ON() if AC_ERR_DEV or
AC_ERR_HSM is not set. PHY events may trigger HSM_ST_ERR with other
error codes and, with or without it, there just isn't much reason to
do WARN_ON() on it. Even if error code is not set there, core EH
logic won't have any problem dealing with the error condition.
OSDL bz#11065 reports this problem.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
drivers/ata/libata-sff.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
index 304fdc6..2a4c516 100644
--- a/drivers/ata/libata-sff.c
+++ b/drivers/ata/libata-sff.c
@@ -1315,11 +1315,6 @@ fsm_start:
break;
case HSM_ST_ERR:
- /* make sure qc->err_mask is available to
- * know what's wrong and recover
- */
- WARN_ON(!(qc->err_mask & (AC_ERR_DEV | AC_ERR_HSM)));
-
ap->hsm_task_state = HSM_ST_IDLE;
/* complete taskfile transaction */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH #upstream-fixes] libata-sff: kill spurious WARN_ON() in ata_hsm_move()
2008-08-29 14:27 [PATCH #upstream-fixes] libata-sff: kill spurious WARN_ON() in ata_hsm_move() Tejun Heo
@ 2008-09-08 16:16 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-09-08 16:16 UTC (permalink / raw)
To: Tejun Heo; +Cc: IDE/ATA development list
Tejun Heo wrote:
> On HSM_ST_ERR, ata_hsm_move() triggers WARN_ON() if AC_ERR_DEV or
> AC_ERR_HSM is not set. PHY events may trigger HSM_ST_ERR with other
> error codes and, with or without it, there just isn't much reason to
> do WARN_ON() on it. Even if error code is not set there, core EH
> logic won't have any problem dealing with the error condition.
>
> OSDL bz#11065 reports this problem.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> ---
> drivers/ata/libata-sff.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
> index 304fdc6..2a4c516 100644
> --- a/drivers/ata/libata-sff.c
> +++ b/drivers/ata/libata-sff.c
> @@ -1315,11 +1315,6 @@ fsm_start:
> break;
>
> case HSM_ST_ERR:
> - /* make sure qc->err_mask is available to
> - * know what's wrong and recover
> - */
> - WARN_ON(!(qc->err_mask & (AC_ERR_DEV | AC_ERR_HSM)));
> -
> ap->hsm_task_state = HSM_ST_IDLE;
>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-08 16:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-29 14:27 [PATCH #upstream-fixes] libata-sff: kill spurious WARN_ON() in ata_hsm_move() Tejun Heo
2008-09-08 16:16 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).