From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Elias Oltmanns <eo@nebensachen.de>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ide: Build fix for CONFIG_IDE_PROC_FS=n
Date: Sat, 30 Aug 2008 15:19:18 +0400 [thread overview]
Message-ID: <48B92CB6.2090702@ru.mvista.com> (raw)
In-Reply-To: <20080829213217.4826.91622.stgit@denkblock.local>
Hello.
Elias Oltmanns wrote:
> Recent changes have broken compilation when CONFIG_IDE_PROC_FS is not set.
>
> Signed-off-by: Elias Oltmanns <eo@nebensachen.de>
>
[...]
> diff --git a/drivers/ide/ide-disk.h b/drivers/ide/ide-disk.h
> index f937772..5254cae 100644
> --- a/drivers/ide/ide-disk.h
> +++ b/drivers/ide/ide-disk.h
> @@ -23,8 +23,10 @@ ide_decl_devset(acoustic);
> /* ide-disk_ioctl.c */
> int ide_disk_ioctl(struct inode *, struct file *, unsigned int, unsigned long);
>
> +#ifdef CONFIG_IDE_PROC_FS
> /* ide-disk_proc.c */
> extern ide_proc_entry_t ide_disk_proc[];
> extern const struct ide_proc_devset ide_disk_settings[];
> +#endif /* CONFIG_IDE_PROC_FS */
>
> #endif /* __IDE_DISK_H */
> diff --git a/drivers/ide/ide-floppy.h b/drivers/ide/ide-floppy.h
> index 2ad373e..86ee37e 100644
> --- a/drivers/ide/ide-floppy.h
> +++ b/drivers/ide/ide-floppy.h
> @@ -53,8 +53,10 @@ sector_t ide_floppy_capacity(ide_drive_t *);
> /* ide-floppy_ioctl.c */
> int ide_floppy_ioctl(struct inode *, struct file *, unsigned, unsigned long);
>
> +#ifdef CONFIG_IDE_PROC_FS
> /* ide-floppy_proc.c */
> extern ide_proc_entry_t ide_floppy_proc[];
> extern const struct ide_proc_devset ide_floppy_settings[];
> +#endif /* CONFIG_IDE_PROC_FS */
>
Is surrounding 'extern' declarations by #ifdef's really of any value?
They shouldn't be used if CONFIG_IDE_PROC_FS=n, so no object file
records should be generated.
WBR, Sergei
next prev parent reply other threads:[~2008-08-30 11:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-29 21:37 [PATCH] ide: Build fix for CONFIG_IDE_PROC_FS=n Elias Oltmanns
2008-08-30 11:19 ` Sergei Shtylyov [this message]
2008-08-30 11:22 ` Sergei Shtylyov
2008-08-30 16:23 ` Elias Oltmanns
2008-08-30 16:29 ` Sergei Shtylyov
2008-08-31 15:52 ` Bartlomiej Zolnierkiewicz
2008-09-01 22:52 ` Elias Oltmanns
2008-09-02 10:35 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B92CB6.2090702@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=eo@nebensachen.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).