From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] ahci: Fix long standing Marvell regressions Date: Wed, 03 Sep 2008 09:42:54 -0400 Message-ID: <48BE945E.4090106@garzik.org> References: <20080903000538.7500eaf8@lxorguk.ukuu.org.uk> <48BDCF09.7000603@garzik.org> <20080903142941.3f25d235@lxorguk.ukuu.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:46485 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751686AbYICNnE (ORCPT ); Wed, 3 Sep 2008 09:43:04 -0400 In-Reply-To: <20080903142941.3f25d235@lxorguk.ukuu.org.uk> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Alan Cox Cc: torvalds@osdl.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Alan Cox wrote: > The actual fix for the moment is very simple. If the user has included > the pata_marvell driver let it drive the ports. If they've only selected > for SATA support give them the AHCI driver which will run the port a fraction > faster. Allow the user to control this decision via ahci.marvell_enable as > a module parameter so that distributions can ship 'it works' defaults and > smarter users (or config tools) can then flip it over it desired. > > > Signed-off-by: Alan Cox > --- > > drivers/ata/Kconfig | 6 ++++-- > drivers/ata/ahci.c | 19 +++++++++++++++++++ > 2 files changed, 23 insertions(+), 2 deletions(-) [snip] That's far more reasonable, and I'd be happy to queue that with your full email text... Unless you object, I'll roll this up with a couple other libata fixes for 2.6.27-rc. Jeff