From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org, alan@lxorguk.ukuu.org.uk,
JosephChan@via.com.tw
Subject: Re: [PATCH 5/5] ata_piix: drop merged SCR access and use slave_link instead
Date: Thu, 04 Sep 2008 06:36:00 -0400 [thread overview]
Message-ID: <48BFBA10.9010102@garzik.org> (raw)
In-Reply-To: <1217491364-19725-6-git-send-email-tj@kernel.org>
Tejun Heo wrote:
> Now that libata has slave_link, there's no need to keep ugly merged
> SCR access. Drop it and use slave_link instead. This results in
> simpler code and much better separate link handling for master and
> slave.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
ACK patchset, patches 1-5
My only comment is that it would be nice to start moving libata closer
to SAS, since this seems to parallel some SAS concepts.
now, off to Puerto Rico for a long weekend!
next prev parent reply other threads:[~2008-09-04 10:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-31 8:02 [PATCHSET #upstream] libata: implement slave_link Tejun Heo
2008-07-31 8:02 ` [PATCH 1/5] libata: make SCR access ops per-link Tejun Heo
2008-09-29 4:33 ` Jeff Garzik
2008-07-31 8:02 ` [PATCH 2/5] libata: reimplement link iterator Tejun Heo
2008-07-31 8:02 ` [PATCH 3/5] libata: misc updates to prepare for slave link Tejun Heo
2008-07-31 8:02 ` [PATCH 4/5] libata: implement slave_link Tejun Heo
2008-07-31 8:02 ` [PATCH 5/5] ata_piix: drop merged SCR access and use slave_link instead Tejun Heo
2008-09-04 10:36 ` Jeff Garzik [this message]
2008-09-04 10:36 ` Tejun Heo
2008-08-13 9:41 ` [PATCHSET #upstream] libata: implement slave_link Tejun Heo
2008-08-13 9:45 ` JosephChan
2008-08-13 10:14 ` Tejun Heo
2008-09-04 9:57 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48BFBA10.9010102@garzik.org \
--to=jeff@garzik.org \
--cc=JosephChan@via.com.tw \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).