linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Lord <liml@rtr.ca>
To: IDE/ATA development list <linux-ide@vger.kernel.org>,
	Jeff Garzik <jgarzik@pobox.com>, Tejun Heo <htejun@gmail.com>
Cc: Petr Jelen <petr.jelen@gmail.com>
Subject: Re: [PATCH] sata_mv: add RocketRaid 1720 PCI ID to driver
Date: Fri, 05 Sep 2008 09:32:07 -0400	[thread overview]
Message-ID: <48C134D7.9040903@rtr.ca> (raw)
In-Reply-To: <48C05F53.2020709@rtr.ca>

Mark Lord wrote:
> Add PCI ID for RocketRAID 1720 to sata_mv.
> 
> Signed-off-by: Petr Jelen <petr.jelen@gmail.com>
> Signed-off-by: Mark Lord <mlord@pobox.com>
> ---
> Resending, with fixed whitespace and a colon on the subject line.  :)
> This is for 2.6.27.  Pretty harmless.
> 
> --- linux-2.6.27-rc4/drivers/ata/sata_mv.c    2008-08-29 
> 21:35:45.000000000 +0200
> +++ linux/drivers/ata/sata_mv.c    2008-08-29 21:36:38.000000000 +0200
> @@ -667,7 +667,8 @@
>     { PCI_VDEVICE(MARVELL, 0x5041), chip_504x },
>     { PCI_VDEVICE(MARVELL, 0x5080), chip_5080 },
>     { PCI_VDEVICE(MARVELL, 0x5081), chip_508x },
> -    /* RocketRAID 1740/174x have different identifiers */
> +    /* RocketRAID 1720/174x have different identifiers */
> +    { PCI_VDEVICE(TTI, 0x1720), chip_6042 },
>     { PCI_VDEVICE(TTI, 0x1740), chip_508x },
>     { PCI_VDEVICE(TTI, 0x1742), chip_508x },
> 
..

Jeff, this is a patch that failed to be picked  up during the 2.6.26 cycle,
so can we please get it into 2.6.27 now?

Even Linus says this kind of trivial driver stuff is okay during -rc:

  Principal Penguin wrote:
  >  - but as a special case, we relax that for totally new drivers (and that 
  >    includes things like just adding a new PCI or USB ID's to old drivers), 
  >    because (a) it can't really regress and (b) support for a specific 
  >    piece of hardware can often be critical.

Thanks

  reply	other threads:[~2008-09-05 13:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-04 22:16 [PATCH] sata_mv add RocketRaid 1720 PCI ID to driver Mark Lord
2008-09-04 22:21 ` [PATCH] sata_mv: " Mark Lord
2008-09-05 13:32   ` Mark Lord [this message]
2008-09-08 16:16   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48C134D7.9040903@rtr.ca \
    --to=liml@rtr.ca \
    --cc=htejun@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=petr.jelen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).