linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: linux@sun7.cn,
	IDE/ATA development list <linux-ide@vger.kernel.org>,
	Jeff Garzik <jeff@garzik.org>, Peer Chen <pchen@nvidia.com>,
	Kuan Luo <kluo@nvidia.com>
Cc: stable@kernel.org
Subject: Re: [PATCH #upstream-fixes] sata_nv: disable hardreset for generic
Date: Mon, 08 Sep 2008 21:17:30 +0200	[thread overview]
Message-ID: <48C57A4A.2050303@kernel.org> (raw)
In-Reply-To: <48B803F8.8000306@kernel.org>

Tejun Heo wrote:
> From 2.6.26, libata is defaulting to hardreset for various reasons one
> of them being unifying probing, hotplug and EH reset paths uniform.
> Previously, broken hardreset could go unnoticed as it wasn't used
> during probing but when something goes wrong or after hotplug the
> problem will surface and bite hard.
> 
> OSDL bug 11195 reports that sata_nv generic flavor falls into this
> category.  Hardreset itself succeeds but PHY stays offline after
> hardreset.  I tried longer debounce timing but the result was the
> same.
> 
>   http://bugzilla.kernel.org/show_bug.cgi?id=11195
> 
> So, it seems we'll have to drop hardreset from the generic flavor.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Peer Chen <pchen@nvidia.com>

This one definitely should go into -stable too.  The original patch is...

http://article.gmane.org/gmane.linux.ide/34077/raw

Thanks.

-- 
tejun

  parent reply	other threads:[~2008-09-08 19:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-03  5:22 [RFC PATCH #upstream-fixes] sata_nv: disable hardreset for generic Tejun Heo
2008-08-04  9:20 ` Peer Chen
2008-08-13  6:51   ` Tejun Heo
2008-08-29 14:13 ` [PATCH " Tejun Heo
2008-09-08 16:16   ` Jeff Garzik
2008-09-08 19:17   ` Tejun Heo [this message]
2008-10-01 23:22     ` [stable] " Greg KH
2008-10-02  0:22       ` Tejun Heo
2008-10-02 19:57         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48C57A4A.2050303@kernel.org \
    --to=tj@kernel.org \
    --cc=jeff@garzik.org \
    --cc=kluo@nvidia.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux@sun7.cn \
    --cc=pchen@nvidia.com \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).