From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] IDE-TAPE NULL terminate strings. Date: Tue, 23 Sep 2008 21:10:43 +0400 Message-ID: <48D92313.3060605@ru.mvista.com> References: <20080921185138.GA16310@localhost> <48D79ABD.8060805@ru.mvista.com> <9ea470500809220656j6dfcf4c9q7a5a4185481ec994@mail.gmail.com> <20080922204129.GA3495@localhost> <48D80949.4080901@ru.mvista.com> <20080923161434.GA4444@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from h155.mvista.com ([63.81.120.155]:42287 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751580AbYIWRJq (ORCPT ); Tue, 23 Sep 2008 13:09:46 -0400 In-Reply-To: <20080923161434.GA4444@localhost> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Mark de Wever Cc: petkovbb@gmail.com, Gadi Oxman , Bartlomiej Zolnierkiewicz , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Mark de Wever wrote: >>>diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c >>>index 1bce84b..c41f5b1 100644 >>>--- a/drivers/ide/ide-tape.c >>>+++ b/drivers/ide/ide-tape.c >>>@@ -2338,7 +2338,7 @@ static void idetape_get_inquiry_results(ide_drive_t *drive) >>> { >>> idetape_tape_t *tape = drive->driver_data; >>> struct ide_atapi_pc pc; >>>- char fw_rev[6], vendor_id[10], product_id[18]; >>>+ char fw_rev[6] = {'\0'}, vendor_id[10] = {'\0'}, product_id[18] = {'\0'}; >> Do you realize how much *absolutely unnecessary* code will this bring >>in? > I did not, I just had a look at the code GCC produced. I did expect much > smaller code, but maybe that's only generated with -Os. My imagination sufficed to foresee how much code a compiler would have to produce to completely initialize the arrays of the *auto* memory class -- even regardless of optimization. And all that mostly to no purpose. >>This is certainly worse than your initial patch (if it was correct). > My initial patch did work, If ide_fixstring() wouldn't have to do any space compression, it would work. If it would have to compress spaces, 2 garbage characters would be copied by it and then printed. > but that doesn't matter much, since Boris > posted another patch based on your suggestions. I like that patch better > as my initial patch. I'm testing it now and I expect it to work. Me too. :-) > Regards, > Mark de Wever WBR, Sergei