From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>, stable@kernel.org
Subject: Re: [PATCH #upstream-fixes] sata_nv: reinstate nv_hardreset() for non generic controllers
Date: Mon, 29 Sep 2008 00:15:58 -0400 [thread overview]
Message-ID: <48E0567E.4050605@garzik.org> (raw)
In-Reply-To: <48DEB605.6090504@kernel.org>
Tejun Heo wrote:
> Commit 2fd673ecf0378ddeeeb87b3605e50212e0c0ddc6 which tried to remove
> hardreset for generic accidentally removed it for all flavors as all
> others were inheriting from nv_generic_ops. This patch reinstates
> nv_hardreset() and puts it into nv_common_ops which all flavors
> inherit from. nv_generic_ops now inherits from nv_common_ops and
> overrides .hardreset to ATA_OP_NULL.
>
> While at it, explain why nv_hardreset and ATA_OP_NULL override are
> necessary.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> ---
> This fixes the following regression.
>
> http://bugzilla.kernel.org/show_bug.cgi?id=11615
>
> Jeff, are you off for the vacation already?
>
> Thanks.
>
> drivers/ata/sata_nv.c | 46 ++++++++++++++++++++++++++++++++++++++++------
> 1 file changed, 40 insertions(+), 6 deletions(-)
applied
Flight leaves in 12 hours! :)
prev parent reply other threads:[~2008-09-29 4:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-27 22:39 [PATCH #upstream-fixes] sata_nv: reinstate nv_hardreset() for non generic controllers Tejun Heo
2008-09-29 4:15 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E0567E.4050605@garzik.org \
--to=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=stable@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).