Re: sata dvdroms fails to be recognized by MCP55 controller with the 2.6.26.5 kernel

Re: sata dvdroms fails to be recognized by MCP55 controller with the 2.6.26.5 kernel

[Andrew Morton]

(cc linux-ide)

On Tue, 30 Sep 2008 00:01:34 +0100 gettinther <gettinther@gmail.com> wrote:

> Hi,
> 
> I'm currently trying to get the 2.6.26.5 kernel to work but cannot get
> the sata dvdrom to be recognized by the MCP55.  The controller works
> with the 2.6.24.4 and 2.6.25.17 kernels.  I had to use
> CONFIG_ACPI_DOCK=y for the 2.6.25.17 but this did not work with the
> 2.6.26.5.  The problem has been confirmed on at least 2 machines.

It's a regression.

> I have tried various boot options (pci=nomsi, acpi=off and any other
> relevant code I could find) but nothing seems to work.  The odd thing
> is the sata dvdrom was recognized twice by the 2.6.26.5 kernel (2
> different kernel tests) for no apparent reason (could not get it to
> work afterward).
> 
> Here's the cut info for each kernel from /var/log/messages (2.6.25.17,
> 2.6.26.5 working, 2.6.26.5 not working).  If you require further
> information I can submit it. I don't want to put too much on the first
> message.
> 
> Thank you
> 
> Cyrille
> 
> Kernel-2.6.25.17, working
> 
> Sep 28 14:49:43 localhost kernel: SCSI subsystem initialized
> Sep 28 14:49:43 localhost kernel: ACPI: PCI Interrupt Link [LSA0]
> enabled at IRQ 23
> Sep 28 14:49:43 localhost kernel: ACPI: PCI Interrupt 0000:00:05.0[A]
> -> Link [LSA0] -> GSI 23 (level, low) -> IRQ 23
> Sep 28 14:49:43 localhost kernel: scsi0 : sata_nv
> Sep 28 14:49:43 localhost kernel: scsi1 : sata_nv
> Sep 28 14:49:43 localhost kernel: ata1: SATA max UDMA/133 cmd 0xc480
> ctl 0xc400 bmdma 0xbc00 irq 23
> Sep 28 14:49:43 localhost kernel: ata2: SATA max UDMA/133 cmd 0xc080
> ctl 0xc000 bmdma 0xbc08 irq 23
> Sep 28 14:49:43 localhost kernel: ata1: SATA link up 3.0 Gbps (SStatus
> 123 SControl 300)
> Sep 28 14:49:43 localhost kernel: ata1.00: ATA-7: ST3120211AS, 3.AAE,
> max UDMA/133
> Sep 28 14:49:43 localhost kernel: ata1.00: 234441648 sectors, multi
> 16: LBA48 NCQ (depth 0/32)
> Sep 28 14:49:43 localhost kernel: ata1.00: configured for UDMA/133
> Sep 28 14:49:43 localhost kernel: input: ImPS/2 Generic Wheel Mouse as
> /class/input/input1
> Sep 28 14:49:43 localhost kernel: ata2: SATA link up 1.5 Gbps (SStatus
> 113 SControl 300)
> Sep 28 14:49:43 localhost kernel: ata2.00: ATAPI: DVDRW IDE H16X, VER
> B02K, max UDMA/33
> Sep 28 14:49:43 localhost kernel: ata2.00: applying bridge limits
> Sep 28 14:49:43 localhost kernel: ata2.00: configured for UDMA/33
> Sep 28 14:49:43 localhost kernel: scsi 0:0:0:0: Direct-Access     ATA
>     ST3120211AS      3.AA PQ: 0 ANSI: 5
> Sep 28 14:49:43 localhost kernel: scsi 1:0:0:0: CD-ROM
> DVDRW    IDE H16X         B02K PQ: 0 ANSI: 5
> 
> Kernel-2.6.26.5, Successful launch
> 
> Sep 28 14:52:39 localhost kernel: SCSI subsystem initialized
> Sep 28 14:52:39 localhost kernel: ACPI: PCI Interrupt Link [LSA0]
> enabled at IRQ 23
> Sep 28 14:52:39 localhost kernel: ACPI: PCI Interrupt 0000:00:05.0[A]
> -> Link [LSA0] -> GSI 23 (level, low) -> IRQ 23
> Sep 28 14:52:39 localhost kernel: sata_nv 0000:00:05.0: Using SWNCQ mode
> Sep 28 14:52:39 localhost kernel: scsi0 : sata_nv
> Sep 28 14:52:39 localhost kernel: scsi1 : sata_nv
> Sep 28 14:52:39 localhost kernel: ata1: SATA max UDMA/133 cmd 0xc480
> ctl 0xc400 bmdma 0xbc00 irq 23
> Sep 28 14:52:39 localhost kernel: ata2: SATA max UDMA/133 cmd 0xc080
> ctl 0xc000 bmdma 0xbc08 irq 23
> Sep 28 14:52:39 localhost kernel: ata1: SATA link up 3.0 Gbps (SStatus
> 123 SControl 300)
> Sep 28 14:52:39 localhost kernel: ata1.00: ATA-7: ST3120211AS, 3.AAE,
> max UDMA/133
> Sep 28 14:52:39 localhost kernel: ata1.00: 234441648 sectors, multi
> 16: LBA48 NCQ (depth 31/32)
> Sep 28 14:52:39 localhost kernel: ata1.00: configured for UDMA/133
> Sep 28 14:52:39 localhost kernel: input: ImPS/2 Generic Wheel Mouse as
> /class/input/input1
> Sep 28 14:52:39 localhost kernel: ata2: SATA link up 1.5 Gbps (SStatus
> 113 SControl 300)
> Sep 28 14:52:39 localhost kernel: ata2.00: ATAPI: DVDRW IDE H16X, VER
> B02K, max UDMA/33
> Sep 28 14:52:39 localhost kernel: ata2.00: applying bridge limits
> Sep 28 14:52:39 localhost kernel: ata2.00: Drive reports diagnostics
> failure. This may indicate a drive
> Sep 28 14:52:39 localhost kernel: ata2.00: fault or invalid emulation.
> Contact drive vendor for information.
> Sep 28 14:52:39 localhost kernel: ata2.00: configured for UDMA/33
> Sep 28 14:52:39 localhost kernel: scsi 0:0:0:0: Direct-Access     ATA
>     ST3120211AS      3.AA PQ: 0 ANSI: 5
> Sep 28 14:52:39 localhost kernel: scsi 1:0:0:0: CD-ROM
> DVDRW    IDE H16X         B02K PQ: 0 ANSI: 5
> 
> Kernel-2.6.26.5, Failed launches
> 
> Sep 28 15:08:11 localhost syslogd 1.4.1: restart.
> Sep 28 15:08:11 localhost INIT: Loading ACPI module wmi: successfull
> Sep 28 15:08:11 localhost kernel: klogd 1.4.1, log source = /proc/kmsg started.
> Sep 28 15:08:11 localhost kernel: Inspecting /boot/System.map-2.6.26.5.tex3
> Sep 28 15:08:11 localhost crond[2823]: (CRON) STARTUP (V5.0)
> Sep 28 15:08:12 localhost kernel: Loaded 29671 symbols from
> /boot/System.map-2.6.26.5.tex3.
> Sep 28 15:08:12 localhost kernel: Symbols match kernel version 2.6.26.
> Sep 28 15:08:12 localhost kernel: No module symbols loaded - kernel
> modules not enabled.
> Sep 28 15:08:12 localhost kernel: ta1: SATA link up 3.0 Gbps (SStatus
> 123 SControl 300)
> Sep 28 15:08:12 localhost kernel: ata1.00: ATA-7: ST3120211AS, 3.AAE,
> max UDMA/133
> Sep 28 15:08:12 localhost kernel: ata1.00: 234441648 sectors, multi
> 16: LBA48 NCQ (depth 31/32)
> Sep 28 15:08:12 localhost kernel: ata1.00: configured for UDMA/133
> Sep 28 15:08:12 localhost kernel: input: ImPS/2 Generic Wheel Mouse as
> /class/input/input1
> Sep 28 15:08:12 localhost kernel: ata2: SATA link up 1.5 Gbps (SStatus
> 113 SControl 300)
> Sep 28 15:08:12 localhost kernel: ata2.00: qc timeout (cmd 0xa1)
> Sep 28 15:08:12 localhost kernel: ata2.00: failed to IDENTIFY (I/O
> error, err_mask=0x4)
> Sep 28 15:08:12 localhost kernel: ata2: failed to recover some
> devices, retrying in 5 secs
> Sep 28 15:08:12 localhost kernel: ata2: SATA link up 1.5 Gbps (SStatus
> 113 SControl 300)
> Sep 28 15:08:12 localhost kernel: ata2.00: qc timeout (cmd 0xa1)
> Sep 28 15:08:12 localhost kernel: ata2.00: failed to IDENTIFY (I/O
> error, err_mask=0x4)
> Sep 28 15:08:12 localhost kernel: ata2: failed to recover some
> devices, retrying in 5 secs
> Sep 28 15:08:12 localhost kernel: ata2: SATA link up 1.5 Gbps (SStatus
> 113 SControl 300)
> Sep 28 15:08:12 localhost kernel: ata2.00: qc timeout (cmd 0xa1)
> Sep 28 15:08:12 localhost kernel: ata2.00: failed to IDENTIFY (I/O
> error, err_mask=0x4)
> Sep 28 15:08:12 localhost kernel: ata2: failed to recover some
> devices, retrying in 5 secs
> Sep 28 15:08:12 localhost kernel: ata2: SATA link up 1.5 Gbps (SStatus
> 113 SControl 300)
> Sep 28 15:08:12 localhost kernel: scsi 0:0:0:0: Direct-Access     ATA
>     ST3120211AS      3.AA PQ: 0 ANSI: 5
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Re: sata dvdroms fails to be recognized by MCP55 controller with the 2.6.26.5 kernel

[Tejun Heo]

Andrew Morton wrote:
> (cc linux-ide)
> 
> On Tue, 30 Sep 2008 00:01:34 +0100 gettinther <gettinther@gmail.com> wrote:
> 
>> Hi,
>>
>> I'm currently trying to get the 2.6.26.5 kernel to work but cannot get
>> the sata dvdrom to be recognized by the MCP55.  The controller works
>> with the 2.6.24.4 and 2.6.25.17 kernels.  I had to use
>> CONFIG_ACPI_DOCK=y for the 2.6.25.17 but this did not work with the
>> 2.6.26.5.  The problem has been confirmed on at least 2 machines.
> 
> It's a regression.
> 
>> I have tried various boot options (pci=nomsi, acpi=off and any other
>> relevant code I could find) but nothing seems to work.  The odd thing
>> is the sata dvdrom was recognized twice by the 2.6.26.5 kernel (2
>> different kernel tests) for no apparent reason (could not get it to
>> work afterward).
>>
>> Here's the cut info for each kernel from /var/log/messages (2.6.25.17,
>> 2.6.26.5 working, 2.6.26.5 not working).  If you require further
>> information I can submit it. I don't want to put too much on the first
>> message.

Does irqpoll help?

-- 
tejun

Re: sata dvdroms fails to be recognized by MCP55 controller with the 2.6.26.5 kernel

[Tejun Heo]

(restoring lkml and linux-ide.  please don't drop cc list)

Tejun Heo wrote:
> Hello,
> 
> gettinther wrote:
>> 00:05.2 IDE interface: GeForce 8800 GT 512 MCP55 SATA Controller (rev
>> a2) (prog-if 85 [Master SecO PriO])
> 
> Ah.. okay.  MCP55.  I've missed that part in the first message.
> sata_nv is a bit messed up for 2.6.26.  What happened was...
> 
> * During 2.6.26-rc, libata switched to prefer hardreset over softreset
>   for various reasons.
> 
> * After 2.6.26 release, sata_nv generic flavors (MCP55/66) were
>   reported to have problems probing devices with hardreset.  Hardreset
>   simply doesn't work.
> 
> * Patch posted to disable hardreset for generic but it accidentally
>   disabled hardreset for all flavors (generic/nf2/3/ck804).
> 
> * Which broke ck804.
> 
> * Another patch posted to reinstate hardreset for nf2/3 and ck804.
> 
> * It somehow mysteriously broke nf2/3.  This is still being
>   investigated.
> 
> Sorry about the mess but I am puzzled too.  I'll report back when I
> know more.
> 
> Thanks.
> 


-- 
tejun

Re: sata dvdroms fails to be recognized by MCP55 controller with the 2.6.26.5 kernel

[gettinther]

On Sat, Oct 4, 2008 at 8:27 AM, Tejun Heo <htejun@gmail.com> wrote:
> (restoring lkml and linux-ide.  please don't drop cc list)
>
> Tejun Heo wrote:
>> Hello,
>>
>> gettinther wrote:
>>> 00:05.2 IDE interface: GeForce 8800 GT 512 MCP55 SATA Controller (rev
>>> a2) (prog-if 85 [Master SecO PriO])
>>
>> Ah.. okay.  MCP55.  I've missed that part in the first message.
>> sata_nv is a bit messed up for 2.6.26.  What happened was...
>>
>> * During 2.6.26-rc, libata switched to prefer hardreset over softreset
>>   for various reasons.
>>
>> * After 2.6.26 release, sata_nv generic flavors (MCP55/66) were
>>   reported to have problems probing devices with hardreset.  Hardreset
>>   simply doesn't work.
>>
>> * Patch posted to disable hardreset for generic but it accidentally
>>   disabled hardreset for all flavors (generic/nf2/3/ck804).
>>
>> * Which broke ck804.
>>
>> * Another patch posted to reinstate hardreset for nf2/3 and ck804.
>>
>> * It somehow mysteriously broke nf2/3.  This is still being
>>   investigated.
>>
>> Sorry about the mess but I am puzzled too.  I'll report back when I
>> know more.
>>
>> Thanks.
>>
>
>
> --
> tejun
>

Tejun,

I have tested the patch you sent me and it solves the issue with the
sata dvdrom detection with the 2.6.27.rc8.  The issue is still present
on the 2.6.26.5 kernel.  Are you backporting the solution to that
kernel?

Thank you very much for the fix.

I post below the patch for record.

diff --git a/drivers/ata/sata_nv.c b/drivers/ata/sata_nv.c
index 14601dc..ce77619 100644
--- a/drivers/ata/sata_nv.c
+++ b/drivers/ata/sata_nv.c
@@ -309,8 +309,6 @@ static void nv_nf2_freeze(struct ata_port *ap);
 static void nv_nf2_thaw(struct ata_port *ap);
 static void nv_ck804_freeze(struct ata_port *ap);
 static void nv_ck804_thaw(struct ata_port *ap);
-static int nv_hardreset(struct ata_link *link, unsigned int *class,
-			unsigned long deadline);
 static int nv_adma_slave_config(struct scsi_device *sdev);
 static int nv_adma_check_atapi_dma(struct ata_queued_cmd *qc);
 static void nv_adma_qc_prep(struct ata_queued_cmd *qc);
@@ -405,17 +403,8 @@ static struct scsi_host_template nv_swncq_sht = {
 	.slave_configure	= nv_swncq_slave_config,
 };

-/* OSDL bz3352 reports that some nv controllers can't determine device
- * signature reliably and nv_hardreset is implemented to work around
- * the problem.  This was reported on nf3 and it's unclear whether any
- * other controllers are affected.  However, the workaround has been
- * applied to all variants and there isn't much to gain by trying to
- * find out exactly which ones are affected at this point especially
- * because NV has moved over to ahci for newer controllers.
- */
 static struct ata_port_operations nv_common_ops = {
 	.inherits		= &ata_bmdma_port_ops,
-	.hardreset		= nv_hardreset,
 	.scr_read		= nv_scr_read,
 	.scr_write		= nv_scr_write,
 };
@@ -429,12 +418,17 @@ static struct ata_port_operations nv_generic_ops = {
 	.hardreset		= ATA_OP_NULL,
 };

+/* OSDL bz3352 reports that nf2/3 controllers can't determine device
+ * signature reliably.  Use sata_std_hardreset().
+ */
 static struct ata_port_operations nv_nf2_ops = {
 	.inherits		= &nv_common_ops,
 	.freeze			= nv_nf2_freeze,
 	.thaw			= nv_nf2_thaw,
+	.hardreset		= sata_std_hardreset,
 };

+/* CK804 finally gets hardreset right */
 static struct ata_port_operations nv_ck804_ops = {
 	.inherits		= &nv_common_ops,
 	.freeze			= nv_ck804_freeze,
@@ -443,7 +437,7 @@ static struct ata_port_operations nv_ck804_ops = {
 };

 static struct ata_port_operations nv_adma_ops = {
-	.inherits		= &nv_common_ops,
+	.inherits		= &nv_ck804_ops,

 	.check_atapi_dma	= nv_adma_check_atapi_dma,
 	.sff_tf_read		= nv_adma_tf_read,
@@ -467,7 +461,7 @@ static struct ata_port_operations nv_adma_ops = {
 };

 static struct ata_port_operations nv_swncq_ops = {
-	.inherits		= &nv_common_ops,
+	.inherits		= &nv_generic_ops,

 	.qc_defer		= ata_std_qc_defer,
 	.qc_prep		= nv_swncq_qc_prep,
@@ -1605,21 +1599,6 @@ static void nv_mcp55_thaw(struct ata_port *ap)
 	ata_sff_thaw(ap);
 }

-static int nv_hardreset(struct ata_link *link, unsigned int *class,
-			unsigned long deadline)
-{
-	int rc;
-
-	/* SATA hardreset fails to retrieve proper device signature on
-	 * some controllers.  Request follow up SRST.  For more info,
-	 * see http://bugzilla.kernel.org/show_bug.cgi?id=3352
-	 */
-	rc = sata_sff_hardreset(link, class, deadline);
-	if (rc)
-		return rc;
-	return -EAGAIN;
-}
-
 static void nv_adma_error_handler(struct ata_port *ap)
 {
 	struct nv_adma_port_priv *pp = ap->private_data;

Re: sata dvdroms fails to be recognized by MCP55 controller with the 2.6.26.5 kernel

[Tejun Heo]

gettinther wrote:
> I have tested the patch you sent me and it solves the issue with the
> sata dvdrom detection with the 2.6.27.rc8.  The issue is still present
> on the 2.6.26.5 kernel.  Are you backporting the solution to that
> kernel?

It seems nf2/3 still have issues.  Once nf2/3 are cleared, I'll
forward the patch to -stable.

Thanks.

-- 
tejun

Re: sata dvdroms fails to be recognized by MCP55 controller with the 2.6.26.5 kernel

[gettinther]

On Tue, Oct 7, 2008 at 2:10 AM, Tejun Heo <htejun@gmail.com> wrote:
> gettinther wrote:
>> I have tested the patch you sent me and it solves the issue with the
>> sata dvdrom detection with the 2.6.27.rc8.  The issue is still present
>> on the 2.6.26.5 kernel.  Are you backporting the solution to that
>> kernel?
>
> It seems nf2/3 still have issues.  Once nf2/3 are cleared, I'll
> forward the patch to -stable.
>
> Thanks.
>
> --
> tejun
>

Tejun,

I applied your patch to the 2.6.26 tree (slightly modified to suit)
and it also fixes the issue there.
I can post the patch this evening if you want to.

Thank you again,

Cyrille

Re: sata dvdroms fails to be recognized by MCP55 controller with the 2.6.26.5 kernel

[gettinther]

On Fri, Oct 10, 2008 at 10:07 AM, gettinther <gettinther@gmail.com> wrote:
> On Tue, Oct 7, 2008 at 2:10 AM, Tejun Heo <htejun@gmail.com> wrote:
>> gettinther wrote:
>>> I have tested the patch you sent me and it solves the issue with the
>>> sata dvdrom detection with the 2.6.27.rc8.  The issue is still present
>>> on the 2.6.26.5 kernel.  Are you backporting the solution to that
>>> kernel?
>>
>> It seems nf2/3 still have issues.  Once nf2/3 are cleared, I'll
>> forward the patch to -stable.
>>
>> Thanks.
>>
>> --
>> tejun
>>
>
> Tejun,
>
> I applied your patch to the 2.6.26 tree (slightly modified to suit)
> and it also fixes the issue there.
> I can post the patch this evening if you want to.
>
> Thank you again,
>
> Cyrille
>

Here's the patch I applied

--- a/drivers/ata/sata_nv.c.old	2008-07-13 22:51:29.000000000 +0100
+++ a/drivers/ata/sata_nv.c	2008-10-10 00:45:14.000000000 +0100
@@ -309,8 +309,6 @@
 static void nv_nf2_thaw(struct ata_port *ap);
 static void nv_ck804_freeze(struct ata_port *ap);
 static void nv_ck804_thaw(struct ata_port *ap);
-static int nv_hardreset(struct ata_link *link, unsigned int *class,
-			unsigned long deadline);
 static int nv_adma_slave_config(struct scsi_device *sdev);
 static int nv_adma_check_atapi_dma(struct ata_queued_cmd *qc);
 static void nv_adma_qc_prep(struct ata_queued_cmd *qc);
@@ -407,7 +405,6 @@

 static struct ata_port_operations nv_generic_ops = {
 	.inherits		= &ata_bmdma_port_ops,
-	.hardreset		= nv_hardreset,
 	.scr_read		= nv_scr_read,
 	.scr_write		= nv_scr_write,
 };
@@ -416,6 +413,7 @@
 	.inherits		= &nv_generic_ops,
 	.freeze			= nv_nf2_freeze,
 	.thaw			= nv_nf2_thaw,
+	.hardreset		= sata_std_hardreset,
 };

 static struct ata_port_operations nv_ck804_ops = {
@@ -1588,21 +1586,6 @@
 	ata_sff_thaw(ap);
 }

-static int nv_hardreset(struct ata_link *link, unsigned int *class,
-			unsigned long deadline)
-{
-	int rc;
-
-	/* SATA hardreset fails to retrieve proper device signature on
-	 * some controllers.  Request follow up SRST.  For more info,
-	 * see http://bugzilla.kernel.org/show_bug.cgi?id=3352
-	 */
-	rc = sata_sff_hardreset(link, class, deadline);
-	if (rc)
-		return rc;
-	return -EAGAIN;
-}
-
 static void nv_adma_error_handler(struct ata_port *ap)
 {
 	struct nv_adma_port_priv *pp = ap->private_data;