From: Tejun Heo <tj@kernel.org>
To: Elias Oltmanns <eo@nebensachen.de>
Cc: Jeff Garzik <jeff@garzik.org>, linux-ide@vger.kernel.org
Subject: Re: libata: Fix a potential race condition in ata_scsi_park_show()
Date: Sun, 05 Oct 2008 05:17:40 +0900 [thread overview]
Message-ID: <48E7CF64.4050206@kernel.org> (raw)
In-Reply-To: <87prmgzohf.fsf@denkblock.local>
Elias Oltmanns wrote:
> Peter Moulder has pointed out that there is a slight chance that a
> negative value might be passed to jiffies_to_msecs() in
> ata_scsi_park_show(). This is fixed by saving the value of jiffies in a
> local variable, thus also reducing code since the volatile variable
> jiffies is accessed only once.
>
> Signed-off-by: Elias Oltmanns <eo@nebensachen.de>
added to #tj-upstream. Thanks.
--
tejun
next prev parent reply other threads:[~2008-10-04 20:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-04 9:41 libata: Fix a potential race condition in ata_scsi_park_show() Elias Oltmanns
2008-10-04 20:17 ` Tejun Heo [this message]
2008-10-30 21:39 ` Elias Oltmanns
2008-10-31 2:26 ` Tejun Heo
2008-10-31 5:40 ` Jeff Garzik
2008-11-03 9:54 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E7CF64.4050206@kernel.org \
--to=tj@kernel.org \
--cc=eo@nebensachen.de \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).