From: Tejun Heo <tj@kernel.org>
To: John Clark <clarkjc@runbox.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: Interoperability problem with Quantum CD72SH SATA tape drive and libata
Date: Tue, 07 Oct 2008 10:29:23 +0900 [thread overview]
Message-ID: <48EABB73.5080002@kernel.org> (raw)
In-Reply-To: <48EA68D7.3060701@runbox.com>
John Clark wrote:
> Tejun Heo wrote:
>> Can you please test the attached patch?
>>
>> Alan, John Clark is reporting that the above tape drive chokes on odd
>> byte PIO transfer, so the default condition check (qc->nbytes & 15) in
>> atapi_check_dma() breaks the SATA tape drive, so there's always one
>> which breaks the other way around. :-(
>>
>> For the time being, I think the horkage should do. I was wondering
>> whether you still think we should lift the default mod16 check in
>> atapi_check_dma().
>>
>> Thanks.
>>
>
> Tejun,
>
> I have tested the patch you supplied. It works, as expected.
applied to #tj-upstream. Thanks.
--
tejun
prev parent reply other threads:[~2008-10-07 1:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-27 20:25 Interoperability problem with Quantum CD72SH SATA tape drive and libata John Clark
2008-10-01 3:21 ` Tejun Heo
2008-10-01 23:13 ` John Clark
2008-10-04 20:45 ` Tejun Heo
2008-10-06 19:36 ` John Clark
2008-10-07 1:29 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48EABB73.5080002@kernel.org \
--to=tj@kernel.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=clarkjc@runbox.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).