From: Tejun Heo <tj@kernel.org>
To: gettinther <gettinther@gmail.com>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
lists@ku-gbr.de, linux@sun7.cn, Robert Hancock <hancockr@shaw.ca>
Subject: Re: Can you please test the attached patch for nv hardreset problem?
Date: Wed, 15 Oct 2008 14:22:19 +0900 [thread overview]
Message-ID: <48F57E0B.6050403@kernel.org> (raw)
In-Reply-To: <64630f150810141431r1d070cddl1c2a6b32ae80b64c@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 720 bytes --]
gettinther wrote:
> The log simply ignores the drive altogether.
>
> from the sound coming from the drive, it does seem that the drive
> initially starts at boot, then stops. After that stage the device
> detection takes place. as the item is a pata to sata converter
> (emulated sata), it does not support hot plugging.
>
> I also need to mention that this behavior (start-stop during boot) did
> not happen on the 2.6.24 and I need to check the 2.6.27. However the
> device is detected by both of these kernels.
Hmmm...
> Oct 14 21:18:12 localhost kernel: ata2: SATA link up 1.5 Gbps (SStatus
> 113 SControl 300)
Hmmm... Can you please apply the attached patch on top of it and
report the boot log?
--
tejun
[-- Attachment #2: debug.patch --]
[-- Type: text/x-patch, Size: 922 bytes --]
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index e97afce..1fc4f80 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -1160,6 +1160,8 @@ unsigned int ata_dev_classify(const struct ata_taskfile *tf)
* We follow the current spec and consider that 0x69/0x96
* identifies a port multiplier and 0x3c/0xc3 a SEMB device.
*/
+ printk("XXX classify %02x/%02x\n", tf->lbam, tf->lbah);
+
if ((tf->lbam == 0) && (tf->lbah == 0)) {
DPRINTK("found ATA device by sig\n");
return ATA_DEV_ATA;
@@ -5855,7 +5857,7 @@ int ata_host_register(struct ata_host *host, struct scsi_host_template *sht)
ehi->probe_mask |= ATA_ALL_DEVICES;
ehi->action |= ATA_EH_RESET | ATA_EH_LPM;
- ehi->flags |= ATA_EHI_NO_AUTOPSY | ATA_EHI_QUIET;
+ ehi->flags |= ATA_EHI_NO_AUTOPSY/* | ATA_EHI_QUIET*/;
ap->pflags &= ~ATA_PFLAG_INITIALIZING;
ap->pflags |= ATA_PFLAG_LOADING;
next prev parent reply other threads:[~2008-10-15 5:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-05 0:49 Can you please test the attached patch for nv hardreset problem? Tejun Heo
2008-10-11 23:34 ` gettinther
2008-10-13 8:27 ` Tejun Heo
2008-10-13 19:13 ` gettinther
2008-10-14 1:18 ` Tejun Heo
2008-10-14 21:31 ` gettinther
2008-10-15 5:22 ` Tejun Heo [this message]
2008-10-15 20:23 ` gettinther
2008-10-16 1:44 ` Tejun Heo
2008-10-16 7:04 ` gettinther
2008-10-17 8:25 ` gettinther
2008-10-21 7:02 ` gettinther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F57E0B.6050403@kernel.org \
--to=tj@kernel.org \
--cc=gettinther@gmail.com \
--cc=hancockr@shaw.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux@sun7.cn \
--cc=lists@ku-gbr.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).