* [PATCH 1/3] ide: mask interrupt in ide_config_drive_speed()
@ 2008-10-14 20:18 Sergei Shtylyov
2008-10-15 12:10 ` Sergei Shtylyov
0 siblings, 1 reply; 2+ messages in thread
From: Sergei Shtylyov @ 2008-10-14 20:18 UTC (permalink / raw)
To: bzolnier; +Cc: linux-ide
Apparently, there is no sense in unmasking IRQ on the controller when you call
disable_irq_nosync() before doing this, set the nIEN bit afterwards, and then
unmask IRQ again after the command completion, hence 1 passed to SELECT_MASK()
before issuing the command in ide_config_drive_speed() is probably just a typo.
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
drivers/ide/ide-iops.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/drivers/ide/ide-iops.c
===================================================================
--- linux-2.6.orig/drivers/ide/ide-iops.c
+++ linux-2.6/drivers/ide/ide-iops.c
@@ -840,7 +840,7 @@ int ide_config_drive_speed(ide_drive_t *
udelay(1);
SELECT_DRIVE(drive);
- SELECT_MASK(drive, 0);
+ SELECT_MASK(drive, 1);
udelay(1);
tp_ops->set_irq(hwif, 0);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/3] ide: mask interrupt in ide_config_drive_speed()
2008-10-14 20:18 [PATCH 1/3] ide: mask interrupt in ide_config_drive_speed() Sergei Shtylyov
@ 2008-10-15 12:10 ` Sergei Shtylyov
0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2008-10-15 12:10 UTC (permalink / raw)
To: bzolnier; +Cc: linux-ide
Hello, I wrote:
> Apparently, there is no sense in unmasking IRQ on the controller when you call
> disable_irq_nosync() before doing this, set the nIEN bit afterwards, and then
> unmask IRQ again after the command completion, hence 1 passed to SELECT_MASK()
>
s/1/0/, of course...
> before issuing the command in ide_config_drive_speed() is probably just a typo.
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> drivers/ide/ide-iops.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6/drivers/ide/ide-iops.c
> ===================================================================
> --- linux-2.6.orig/drivers/ide/ide-iops.c
> +++ linux-2.6/drivers/ide/ide-iops.c
> @@ -840,7 +840,7 @@ int ide_config_drive_speed(ide_drive_t *
>
> udelay(1);
> SELECT_DRIVE(drive);
> - SELECT_MASK(drive, 0);
> + SELECT_MASK(drive, 1);
> udelay(1);
> tp_ops->set_irq(hwif, 0);
>
MBR, Sergei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-15 12:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-14 20:18 [PATCH 1/3] ide: mask interrupt in ide_config_drive_speed() Sergei Shtylyov
2008-10-15 12:10 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).