From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 1/2] hpt366: add hpt3xx_disable_fast_irq() helper Date: Thu, 16 Oct 2008 01:19:04 +0400 Message-ID: <48F65E48.8080301@ru.mvista.com> References: <200808021915.03424.bzolnier@gmail.com> <48F50649.9080507@ru.mvista.com> <200810152011.18478.bzolnier@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from gateway-1237.mvista.com ([63.81.120.155]:36727 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753367AbYJOVTK (ORCPT ); Wed, 15 Oct 2008 17:19:10 -0400 In-Reply-To: <200810152011.18478.bzolnier@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Hello. Bartlomiej Zolnierkiewicz wrote: >>> * Factor out disabling of "fast interrupt" prediction from >>> init_hwif_hpt366() to hpt3xx_disable_fast_irq() helper. >>> >>> * Use hpt3xx_disable_fast_irq() in ->init_chipset instead of >>> ->init_hwif method. >>> >>> This is a preparation for adding proper PCI PM support. >>> >>> While at it: >>> >>> * Cache chip type in chip_type variable in hpt3xx_disable_fast_irq(). >>> >>> There should be no functional changes caused by this patch. >>> >> Except a warning. ;-) >> > > Sorry for that but... shit happens. ;) > Compile testing the patches would have helped. ;-) >> You've removed the users of that variable but left the variable itself... >> alas, it's too late to fix the patch. :-/ >> > > Not such a big deal, we just have to make an another one... > > From: Bartlomiej Zolnierkiewicz > Subject: [PATCH] hpt366: fix compile warning > > Fixup for commit 1785192b5310ee25165768f5bb80f13146788e3e > ("hpt366: add hpt3xx_disable_fast_irq() helper"): > > CC drivers/ide/pci/hpt366.o > drivers/ide/pci/hpt366.c: In function `init_hwif_hpt366': > drivers/ide/pci/hpt366.c:1290: warning: unused variable `dev' > > Reported-by: Sergei Shtylyov > Signed-off-by: Bartlomiej Zolnierkiewicz > Duh. I've posted this patch a bit earlier. ;-) MBR, Sergei