From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: ide-dma: fix ide_build_dmatable() for TRM290 Date: Thu, 16 Oct 2008 16:00:07 +0400 Message-ID: <48F72CC7.2040202@ru.mvista.com> References: <200809282241.26289.sshtylyov@ru.mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from h155.mvista.com ([63.81.120.155]:58301 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1756101AbYJPMAM (ORCPT ); Thu, 16 Oct 2008 08:00:12 -0400 In-Reply-To: <200809282241.26289.sshtylyov@ru.mvista.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: bzolnier@gmail.com Cc: linux-ide@vger.kernel.org Hello, I wrote: > Apparently, 'xcount' being 0 does not mean 0 bytes for TRM290; it means 4 bytes, > judging from the code immediately preceding this check. So, we must never try > to "split" the PRD for TRM290. > > This is probably never hit anyway -- with the DMA buffers aligned to at least > 512 bytes and ATAPI DMA not being used for non block I/O commands... > > Signed-off-by: Sergei Shtylyov > Bart, unfortunately, drivers/ide/ide-dma-sff.c has the same mistake -- you probably forgot to modify the patch splitting it from ide-dma.c... :-/ MBR, Sergei