From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: bzolnier@gmail.com
Cc: linux-ide@vger.kernel.org
Subject: Re: ide-dma: fix ide_build_dmatable() for TRM290
Date: Thu, 16 Oct 2008 16:20:40 +0400 [thread overview]
Message-ID: <48F73198.20209@ru.mvista.com> (raw)
In-Reply-To: <48F72CC7.2040202@ru.mvista.com>
Hello, I wrote:
>> Apparently, 'xcount' being 0 does not mean 0 bytes for TRM290; it
>> means 4 bytes, judging from the code immediately preceding this
>> check. So, we must never try
>> to "split" the PRD for TRM290.
>>
>> This is probably never hit anyway -- with the DMA buffers aligned to
>> at least
>> 512 bytes and ATAPI DMA not being used for non block I/O commands...
>>
>> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>>
>
> Bart, unfortunately, drivers/ide/ide-dma-sff.c has the same mistake
> -- you probably forgot to modify the patch splitting it from
> ide-dma.c... :-/
Even the one cleaning up ide_build_dmatable() actually...
MBR, Sergei
next prev parent reply other threads:[~2008-10-16 12:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-28 18:41 ide-dma: fix ide_build_dmatable() for TRM290 Sergei Shtylylov
2008-10-03 16:50 ` Bartlomiej Zolnierkiewicz
2008-10-16 12:00 ` Sergei Shtylyov
2008-10-16 12:20 ` Sergei Shtylyov [this message]
2008-10-16 19:48 ` Bartlomiej Zolnierkiewicz
2008-10-16 22:50 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F73198.20209@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).