From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: bzolnier@gmail.com
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/2] sgiioc4: fix error cleanup path
Date: Mon, 20 Oct 2008 14:17:21 +0400 [thread overview]
Message-ID: <48FC5AB1.8090908@ru.mvista.com> (raw)
In-Reply-To: <200810192213.57242.sshtylyov@ru.mvista.com>
Hello, I wrote:
> The driver "forgot" to call iounmap() if request_mem_region() call failed in
> sgiioc4_ide_setup_pci_device(). While fixing this, rename the 'err' label to
> 'alloc_err' and get rid of the 'err_free' label altogether...
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Don't apply these 2 patches yet, I'm going to recast them to avoid
changing the same code twice...
MBR, Sergei
prev parent reply other threads:[~2008-10-20 10:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-19 18:13 [PATCH 1/2] sgiioc4: fix error cleanup path Sergei Shtylyov
2008-10-20 10:17 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FC5AB1.8090908@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).