Re: [PATCH] pci: use pci_ioremap_bar() in drivers/ide

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

I just wrote:

>> diff --git a/drivers/ide/pci/scc_pata.c b/drivers/ide/pci/scc_pata.c
>> index 9ce1d80..b4be295 100644
>> --- a/drivers/ide/pci/scc_pata.c
>> +++ b/drivers/ide/pci/scc_pata.c

> [...]

>> @@ -557,10 +553,12 @@ static int setup_mmio_scc (struct pci_dev *dev, 
>> const char *name)
>>          return ret;
>>      }
>>  
>> -    if ((ctl_addr = ioremap(ctl_base, ctl_size)) == NULL)
>> +    ctl_addr = pci_ioremap_bar(dev, 0);
>> +    if (!ctl_addr)
>>          goto fail_0;
>>  
>> -    if ((dma_addr = ioremap(dma_base, dma_size)) == NULL)
>> +    dma_addr = pci_ioremap_bar(dev, 1);
>> +    if (!dma_addr)
>>          goto fail_1;
>>  
>>      pci_set_master(dev);

>    An added bonus here is fixing couple checkpatch.pl's warnings.

    Wait, those even were errors, so even better. :-)

MBR, Sergei