* [PATCH #upstream-fixes] libata: initialize port_task when !CONFIG_ATA_SFF
@ 2008-10-20 4:11 Tejun Heo
2008-10-23 0:40 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2008-10-20 4:11 UTC (permalink / raw)
To: Jeff Garzik, IDE/ATA development list; +Cc: stable, Larry Finger
Subject: libata: initialize port_task when !CONFIG_ATA_SFF
ap->port_task was not initialized if !CONFIG_ATA_SFF later triggering
lockdep warning. Make sure it's initialized.
Reported by Larry Finger.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
---
drivers/ata/libata-core.c | 2 ++
1 file changed, 2 insertions(+)
Index: work/drivers/ata/libata-core.c
===================================================================
--- work.orig/drivers/ata/libata-core.c
+++ work/drivers/ata/libata-core.c
@@ -5373,6 +5373,8 @@ struct ata_port *ata_port_alloc(struct a
#ifdef CONFIG_ATA_SFF
INIT_DELAYED_WORK(&ap->port_task, ata_pio_task);
+#else
+ INIT_DELAYED_WORK(&ap->port_task, NULL);
#endif
INIT_DELAYED_WORK(&ap->hotplug_task, ata_scsi_hotplug);
INIT_WORK(&ap->scsi_rescan_task, ata_scsi_dev_rescan);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH #upstream-fixes] libata: initialize port_task when !CONFIG_ATA_SFF
2008-10-20 4:11 [PATCH #upstream-fixes] libata: initialize port_task when !CONFIG_ATA_SFF Tejun Heo
@ 2008-10-23 0:40 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-10-23 0:40 UTC (permalink / raw)
To: Tejun Heo; +Cc: IDE/ATA development list, stable, Larry Finger
Tejun Heo wrote:
> Subject: libata: initialize port_task when !CONFIG_ATA_SFF
>
> ap->port_task was not initialized if !CONFIG_ATA_SFF later triggering
> lockdep warning. Make sure it's initialized.
>
> Reported by Larry Finger.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> drivers/ata/libata-core.c | 2 ++
> 1 file changed, 2 insertions(+)
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-23 0:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-20 4:11 [PATCH #upstream-fixes] libata: initialize port_task when !CONFIG_ATA_SFF Tejun Heo
2008-10-23 0:40 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).