From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>,
IDE/ATA development list <linux-ide@vger.kernel.org>,
stable@kernel.org
Subject: Re: [PATCH #upstream-fixes, UDPATED] libata-eh: fix slave link EH action mask handling
Date: Wed, 22 Oct 2008 20:40:57 -0400 [thread overview]
Message-ID: <48FFC819.9030203@garzik.org> (raw)
In-Reply-To: <48FDBEF1.40508@kernel.org>
Tejun Heo wrote:
> Slave link action mask is transferred to master link and all the EH
> actions are taken by the master link. ata_eh_about_to_do() and
> ata_eh_done() are called with ATA_EH_ALL_ACTIONS to clear the slave
> link actions during transfer. This always sets ATA_PFLAG_RECOVERED
> flag causing spurious "EH complete" messages.
>
> Don't set ATA_PFLAG_RECOVERED for slave link actions.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> ---
> Thanks. Commit message updated.
>
> drivers/ata/libata-eh.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
applied
prev parent reply other threads:[~2008-10-23 0:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 4:47 [PATCH #upstream-fixes] libata-eh: fix slave link EH action mask handling Tejun Heo
2008-10-21 5:12 ` Tejun Heo
2008-10-21 17:00 ` [stable] " Greg KH
2008-10-21 10:47 ` Sergei Shtylyov
2008-10-21 11:37 ` [PATCH #upstream-fixes, UDPATED] " Tejun Heo
2008-10-23 0:40 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FFC819.9030203@garzik.org \
--to=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
--cc=stable@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).