From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH #upstream-fixes 1/4] libata: fix device iteration bugs Date: Sun, 26 Oct 2008 13:47:22 +0300 Message-ID: <49044ABA.7050104@ru.mvista.com> References: <49041323.9020309@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from h155.mvista.com ([63.81.120.155]:19991 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752349AbYJZKr3 (ORCPT ); Sun, 26 Oct 2008 06:47:29 -0400 In-Reply-To: <49041323.9020309@kernel.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: Jeff Garzik , IDE/ATA development list Hello. Tejun Heo wrote: > There were several places where only enabled devices should be > iterated over but device enabledness wasn't checked. > > * IDENTIFY data 40 wire check in cable_is_40wire() > * xfer_mode/ncq_enabled saving in ata_scsi_error() > * DUBIOUS_XFER handling in ata_set_mode() > > While at it, reformat comment in cable_is_40wire(). > > Signed-off-by: Tejun Heo > More nitpicking... :-) > Index: work/drivers/ata/libata-core.c > =================================================================== > --- work.orig/drivers/ata/libata-core.c > +++ work/drivers/ata/libata-core.c > @@ -4169,18 +4169,16 @@ static int cable_is_40wire(struct ata_po > if (ap->cbl == ATA_CBL_PATA40_SHORT) > return 0; > /* If the controller doesn't know we scan > - > - - Note: We look for all 40 wire detects at this point. > - Any 80 wire detect is taken to be 80 wire cable > - because > - - In many setups only the one drive (slave if present) > - will give a valid detect > - - If you have a non detect capable drive you don't > - want it to colour the choice > - */ > + * > + * - Note: We look for all 40 wire detects at this point. Any > + * 80 wire detect is taken to be 80 wire cable because - In > + * many setups only the one drive (slave if present) will > + * give a valid detect - If you have a non detect capable > + * drive you don't want it to colour the choice > + */ > The comment formatting now is worse than it was... I'd drop hyphen before "Note:" and align the bullets under this note (also doing s/If/if/). MBR, Sergei