From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 1/2] tx4938ide: Check minimum cycle time and SHWT range Date: Tue, 28 Oct 2008 02:12:10 +0300 Message-ID: <49064ACA.20200@ru.mvista.com> References: <20081027.223913.128619425.anemo@mba.ocn.ne.jp> <4905CB09.5020805@ru.mvista.com> <20081027.235224.82088530.anemo@mba.ocn.ne.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from gateway-1237.mvista.com ([63.81.120.155]:43197 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751116AbYJ0XMT (ORCPT ); Mon, 27 Oct 2008 19:12:19 -0400 In-Reply-To: <20081027.235224.82088530.anemo@mba.ocn.ne.jp> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Atsushi Nemoto Cc: linux-mips@linux-mips.org, linux-ide@vger.kernel.org, bzolnier@gmail.com, ralf@linux-mips.org Hello. Atsushi Nemoto wrote: > From: Atsushi Nemoto > Subject: [PATCH] tx4938ide: Check minimum cycle time and SHWT range (v2) > > SHWT value is used as address valid to -CSx assertion and -CSx to -DIOx > assertion setup time, and contrarywise, -DIOx to -CSx release and -CSx > release to address invalid hold time, so it actualy applies 4 times and > so constitutes -DIOx recovery time. Check requirement of the recovery > time and cycle time. Also check SHWT maximum value. > > Suggested-by: Sergei Shtylyov > Signed-off-by: Atsushi Nemoto > Acked-by: Sergei Shtylyov > diff --git a/drivers/ide/tx4938ide.c b/drivers/ide/tx4938ide.c > index a0d10a9..796289c 100644 > --- a/drivers/ide/tx4938ide.c > +++ b/drivers/ide/tx4938ide.c > @@ -39,10 +39,17 @@ static void tx4938ide_tune_ebusc(unsigned int ebus_ch, > /* Address-valid to DIOR/DIOW setup */ > shwt = DIV_ROUND_UP(t->setup, cycle); > > + /* -DIOx recovery time (SHWT * 4) and cycle time requirement */ > + while ((shwt * 4 + wt + (wt ? 2 : 3)) * cycle < t->cycle) > Besides, it's worth making 'wt' variable signed, otherwise you're risking underflow when subtracting 2 above... WBR, Sergei