From: Tejun Heo <tj@kernel.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Elias Oltmanns <eo@nebensachen.de>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH 4/4] libata: clean up the SFF code for coding style
Date: Tue, 28 Oct 2008 10:49:31 +0900 [thread overview]
Message-ID: <49066FAB.2080101@kernel.org> (raw)
In-Reply-To: <48FFC6DE.7060605@garzik.org>
Jeff Garzik wrote:
> Alan Cox wrote:
>>>> if (ata_is_atapi(qc->tf.protocol) &&
>>>> - !(qc->dev->flags & ATA_DFLAG_CDB_INTR))
>>>> + !(qc->dev->flags & ATA_DFLAG_CDB_INTR))
>>> Ditto.
>>
>> Its lining up the bracketing but hey I'm not fussed, just twiddling where
>> checkpatch warned and the like.
>>
>>>> - err_out:
>>>> +err_out:
>>> Yes, I've wondered about these myself occasionally. Personally, I don't
>>> insert a blank before those labels either and would be in favour of such
>>> a change. But do we actually have a convention regarding this matter?
>>
>> CodingStyle chapter 7 which is of course overridable by Jeff ;)
>
> libata style has always matched that: labels go in column 1, without
> any preceding whitespace.
Heh... I am the one who is always putting in the extra space there,
mainly because emacs dictates how I format my code. :-) I'll try to turn
it off.
Thanks.
--
tejun
next prev parent reply other threads:[~2008-10-28 1:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 18:08 [PATCH 0/4] Small set of further libata patches Alan Cox
2008-10-17 18:08 ` [PATCH 1/4] pata_ninja32: suspend/resume support Alan Cox
2008-10-28 4:42 ` Jeff Garzik
2008-10-28 9:37 ` Alan Cox
2008-10-17 18:08 ` [PATCH 2/4] libata: Drain data on errors Alan Cox
2008-10-22 15:46 ` Elias Oltmanns
2008-10-22 16:44 ` Alan Cox
2008-10-27 19:14 ` Mark Lord
2008-10-27 21:54 ` Alan Cox
2008-10-17 18:08 ` [PATCH 3/4] libata: Improve timeout handling Alan Cox
2008-10-22 15:47 ` Elias Oltmanns
2008-10-22 16:04 ` Alan Cox
2008-10-17 18:09 ` [PATCH 4/4] libata: clean up the SFF code for coding style Alan Cox
2008-10-22 15:48 ` Elias Oltmanns
2008-10-22 16:02 ` Alan Cox
2008-10-23 0:35 ` Jeff Garzik
2008-10-28 1:49 ` Tejun Heo [this message]
2008-10-28 9:47 ` Elias Oltmanns
2008-10-29 2:05 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49066FAB.2080101@kernel.org \
--to=tj@kernel.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=eo@nebensachen.de \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).