From: Tejun Heo <tj@kernel.org>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH 2.6.28-rc2] sata_promise: proper hardreset
Date: Tue, 28 Oct 2008 11:06:35 +0900 [thread overview]
Message-ID: <490673AB.2090502@kernel.org> (raw)
In-Reply-To: <200810270049.m9R0ngI8027933@harpo.it.uu.se>
Hello, Mikael.
Mikael Pettersson wrote:
> +static int pdc_pata_hardreset(struct ata_link *link, unsigned int *class,
> + unsigned long deadline)
> +{
> + pdc_reset_port(link->ap);
> + return 0;
> +}
You either need to return -EAGAIN here to ask for follow-up SRST or
override softreset. I think pdc_reset_port() doesn't actually reset the
ATA channel, right? In that case, the latter would be the correct thing
to do.
Thanks.
--
tejun
next prev parent reply other threads:[~2008-10-28 2:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-27 0:49 [PATCH 2.6.28-rc2] sata_promise: proper hardreset Mikael Pettersson
2008-10-28 2:06 ` Tejun Heo [this message]
2008-10-28 12:01 ` Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490673AB.2090502@kernel.org \
--to=tj@kernel.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).