linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ahci: Add support for Promise PDC42819
@ 2008-10-23  3:08 Mark Nelson
  2008-10-28  3:57 ` Jeff Garzik
  0 siblings, 1 reply; 4+ messages in thread
From: Mark Nelson @ 2008-10-23  3:08 UTC (permalink / raw)
  To: jeff, linux-ide; +Cc: alan, mikpe, linux-scsi

Add an appropriate entry for the Promise PDC42819 controller. It has an
AHCI mode and so far works correctly with board_ahci.

This chip is found on Promise's FastTrak TX2650 (2 port) and TX4650 (4 port)
software-based RAID cards (for which there is a binary driver, t3sas) and
can be found on some motherboards, for example the MSI K9A2 Platinum,
which calls the chip a Promise T3 controller.

Although this controller also supports SAS devices, its default bootup mode
is AHCI and the binary driver has to do some magic to get the chip into the
appropriate mode to drive SAS disks.

Seeing as no documentation is provided by Promise, adding this entry to the
ahci driver allows the controller to be useful to people as a SATA
controller (with no ill effects on the system if a SAS disk is connected -
probing of the port just times out with "link online but device
misclassified"), without having to resort to using the binary driver. Users
who require SAS or the proprietary software raid can get this functionality
using the binary driver.

Signed-off-by: Mark Nelson <mdnelson8@gmail.com>
---
 drivers/ata/ahci.c |    3 +++
 1 file changed, 3 insertions(+)

Index: libata-dev/drivers/ata/ahci.c
===================================================================
--- libata-dev.orig/drivers/ata/ahci.c
+++ libata-dev/drivers/ata/ahci.c
@@ -588,6 +588,9 @@ static const struct pci_device_id ahci_p
 	{ PCI_VDEVICE(MARVELL, 0x6145), board_ahci_mv },	/* 6145 */
 	{ PCI_VDEVICE(MARVELL, 0x6121), board_ahci_mv },	/* 6121 */

+	/* Promise */
+	{ PCI_VDEVICE(PROMISE, 0x3f20), board_ahci },	/* PDC42819 */
+
 	/* Generic, PCI class code for AHCI */
 	{ PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
 	  PCI_CLASS_STORAGE_SATA_AHCI, 0xffffff, board_ahci },

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ahci: Add support for Promise PDC42819
  2008-10-23  3:08 [PATCH] ahci: Add support for Promise PDC42819 Mark Nelson
@ 2008-10-28  3:57 ` Jeff Garzik
  2008-10-28  5:55   ` Mark Nelson
  0 siblings, 1 reply; 4+ messages in thread
From: Jeff Garzik @ 2008-10-28  3:57 UTC (permalink / raw)
  To: Mark Nelson; +Cc: linux-ide, alan, mikpe, linux-scsi

Mark Nelson wrote:
> Add an appropriate entry for the Promise PDC42819 controller. It has an
> AHCI mode and so far works correctly with board_ahci.
> 
> This chip is found on Promise's FastTrak TX2650 (2 port) and TX4650 (4 port)
> software-based RAID cards (for which there is a binary driver, t3sas) and
> can be found on some motherboards, for example the MSI K9A2 Platinum,
> which calls the chip a Promise T3 controller.
> 
> Although this controller also supports SAS devices, its default bootup mode
> is AHCI and the binary driver has to do some magic to get the chip into the
> appropriate mode to drive SAS disks.
> 
> Seeing as no documentation is provided by Promise, adding this entry to the
> ahci driver allows the controller to be useful to people as a SATA
> controller (with no ill effects on the system if a SAS disk is connected -
> probing of the port just times out with "link online but device
> misclassified"), without having to resort to using the binary driver. Users
> who require SAS or the proprietary software raid can get this functionality
> using the binary driver.
> 
> Signed-off-by: Mark Nelson <mdnelson8@gmail.com>
> ---
>  drivers/ata/ahci.c |    3 +++
>  1 file changed, 3 insertions(+)

applied



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ahci: Add support for Promise PDC42819
  2008-10-28  3:57 ` Jeff Garzik
@ 2008-10-28  5:55   ` Mark Nelson
  2008-10-28  6:02     ` Mark Nelson
  0 siblings, 1 reply; 4+ messages in thread
From: Mark Nelson @ 2008-10-28  5:55 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: linux-ide, alan, mikpe, linux-scsi

On Tue, Oct 28, 2008 at 2:57 PM, Jeff Garzik <jeff@garzik.org> wrote:
> Mark Nelson wrote:
>>
>> Add an appropriate entry for the Promise PDC42819 controller. It has an
>> AHCI mode and so far works correctly with board_ahci.
>>
>> This chip is found on Promise's FastTrak TX2650 (2 port) and TX4650 (4
>> port)
>> software-based RAID cards (for which there is a binary driver, t3sas) and
>> can be found on some motherboards, for example the MSI K9A2 Platinum,
>> which calls the chip a Promise T3 controller.
>>
>> Although this controller also supports SAS devices, its default bootup
>> mode
>> is AHCI and the binary driver has to do some magic to get the chip into
>> the
>> appropriate mode to drive SAS disks.
>>
>> Seeing as no documentation is provided by Promise, adding this entry to
>> the
>> ahci driver allows the controller to be useful to people as a SATA
>> controller (with no ill effects on the system if a SAS disk is connected -
>> probing of the port just times out with "link online but device
>> misclassified"), without having to resort to using the binary driver.
>> Users
>> who require SAS or the proprietary software raid can get this
>> functionality
>> using the binary driver.
>>
>> Signed-off-by: Mark Nelson <mdnelson8@gmail.com>
>> ---
>>  drivers/ata/ahci.c |    3 +++
>>  1 file changed, 3 insertions(+)
>
> applied

Thanks Jeff!

Feel free ignore the v2 I just sent out - it seems like the 0x3f19 cards
never made it out into the wild (or if anyone think it's worth it, I could send
an incremental patch that applies on top of this one)...

Mark

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ahci: Add support for Promise PDC42819
  2008-10-28  5:55   ` Mark Nelson
@ 2008-10-28  6:02     ` Mark Nelson
  0 siblings, 0 replies; 4+ messages in thread
From: Mark Nelson @ 2008-10-28  6:02 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: linux-ide, alan, mikpe, linux-scsi

On Tue, Oct 28, 2008 at 4:55 PM, Mark Nelson <mdnelson8@gmail.com> wrote:
>>> Signed-off-by: Mark Nelson <mdnelson8@gmail.com>
>>> ---
>>>  drivers/ata/ahci.c |    3 +++
>>>  1 file changed, 3 insertions(+)
>>
>> applied
>
> Thanks Jeff!
>
> Feel free ignore the v2 I just sent out - it seems like the 0x3f19 cards
> never made it out into the wild (or if anyone think it's worth it, I could send
> an incremental patch that applies on top of this one)...
>
I just saw your pull request. It's probably better to wait to see if anybody
actually has any cards with the 0x3f19 on there.

Sorry for any confusion.

Thanks!

Mark

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-10-28  6:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-23  3:08 [PATCH] ahci: Add support for Promise PDC42819 Mark Nelson
2008-10-28  3:57 ` Jeff Garzik
2008-10-28  5:55   ` Mark Nelson
2008-10-28  6:02     ` Mark Nelson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).