From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: Pierre Ossman <drzeus-list@drzeus.cx>,
IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH #upstream-fixes] sata_sil24: configure max read request size to 4k
Date: Mon, 27 Oct 2008 23:58:02 -0400 [thread overview]
Message-ID: <49068DCA.8010205@garzik.org> (raw)
In-Reply-To: <4902AE1E.5020504@kernel.org>
Tejun Heo wrote:
> Due to request posting limitations, bandwidth of sil3132 is limited to
> around 120MB/s with the minimum pci-e payload size (128bytes) which is
> used by most consumer systems. However, write throughput can be
> slightly (~3%) increased by increasing the max read requeset size.
> Configure it to 4k which is the maximum supported. This optimization
> is also done by SIMG's windows driver.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> ---
> drivers/ata/sata_sil24.c | 5 +++++
> 1 file changed, 5 insertions(+)
> diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c
> index 4621807..ccee930 100644
> --- a/drivers/ata/sata_sil24.c
> +++ b/drivers/ata/sata_sil24.c
> @@ -1329,6 +1329,11 @@ static int sil24_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> }
> }
>
> + /* Set max read request size to 4096. This slightly increases
> + * write throughput for pci-e variants.
> + */
> + pcie_set_readrq(pdev, 4096);
> +
> sil24_init_controller(host);
>
applied
prev parent reply other threads:[~2008-10-28 3:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-25 5:26 [PATCH #upstream-fixes] sata_sil24: configure max read request size to 4k Tejun Heo
2008-10-28 3:58 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49068DCA.8010205@garzik.org \
--to=jeff@garzik.org \
--cc=drzeus-list@drzeus.cx \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).