From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH] block: add timer on blkdev_dequeue_request() not elv_next_request() Date: Thu, 30 Oct 2008 18:51:25 +0900 Message-ID: <4909839D.1020508@kernel.org> References: <490927CD.2010205@kernel.org> <20081030072956.GL31673@kernel.dk> <49096865.2050006@kernel.org> <20081030075855.GO31673@kernel.dk> <20081030092741.GA9478@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from hera.kernel.org ([140.211.167.34]:33737 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752136AbYJ3Jvg (ORCPT ); Thu, 30 Oct 2008 05:51:36 -0400 In-Reply-To: <20081030092741.GA9478@linux.vnet.ibm.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Mike Anderson Cc: Jens Axboe , James Bottomley , linux-scsi , Linux Kernel , IDE/ATA development list Mike Anderson wrote: > From: Mike Anderson > Date: Thu, 30 Oct 2008 02:16:20 -0700 > Subject: [PATCH 1/1] blk: move blk_delete_timer call in end_that_request_last > > Move the calling blk_delete_timer to later in end_that_request_last to > address an issue where blkdev_dequeue_request may have add a timer for the > request. > > Signed-off-by: Mike Anderson This patch definitely is necessary. Acked-by: Tejun Heo Thanks. -- tejun