linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
	Joseph Chan <JosephChan@via.com.tw>
Subject: Re: [PATCH 1/2 #upstream-fixes] sata_via: fix support for 5287
Date: Fri, 31 Oct 2008 01:45:38 -0400	[thread overview]
Message-ID: <490A9B82.7070704@garzik.org> (raw)
In-Reply-To: <48FDF95C.8090809@kernel.org>

Tejun Heo wrote:
> 5287 used to be treated as vt6420 but it didn't work.  It's new family
> of controllers called vt8251 which hosts four SATA ports as M/S of the
> two ATA ports.  This configuration is rather peculiar in that although
> the M/S devices are on the same port, each have its own SCR (or
> equivalent link status/control) registers which screws up the
> port-link-device hierarchy assumed by libata.  Another controller
> which falls into this category is ata_piix w/ SIDPR access.
> 
> libata now has facility to deal with this class of controllers named
> slave_link.  A low level driver for such controllers can just call
> ata_slave_link_init() on the respective ports and libata will handle
> all the difficult parts like following up with single SRST after
> hardresetting both ports.
> 
> This patch creates new controller class vt8251, implements slave_link
> aware init sequence and config space based SCR access for it and moves
> 5287 to the new class.
> 
> This patch is based on Joseph Chan's larger patch which was created
> before slave_link was implemented in libata.
> 
>   http://thread.gmane.org/gmane.linux.kernel.commits.mm/40640
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Joseph Chan <JosephChan@via.com.tw>
> ---
>  drivers/ata/sata_via.c |  155 +++++++++++++++++++++++++++++++++++++++++++++----
>  1 file changed, 143 insertions(+), 12 deletions(-)

applied



  parent reply	other threads:[~2008-10-31  5:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-21 15:45 [PATCH 1/2 #upstream-fixes] sata_via: load DEVICE register when CTL changes Tejun Heo
2008-10-21 15:46 ` [PATCH 1/2 #upstream-fixes] sata_via: fix support for 5287 Tejun Heo
2008-10-26  6:46   ` Tejun Heo
2008-10-31  5:45   ` Jeff Garzik [this message]
2008-10-23  0:43 ` [PATCH 1/2 #upstream-fixes] sata_via: load DEVICE register when CTL changes Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=490A9B82.7070704@garzik.org \
    --to=jeff@garzik.org \
    --cc=JosephChan@via.com.tw \
    --cc=linux-ide@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).