* [PATCH 5/7] ATA: remove excess kernel-doc notation
@ 2008-10-30 5:35 Randy Dunlap
2008-10-31 5:45 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2008-10-30 5:35 UTC (permalink / raw)
To: ide; +Cc: akpm, jgarzik
From: Randy Dunlap <randy.dunlap@oracle.com>
Remove excess kernel-doc function parameter notation from drivers/ata/:
Warning(drivers/ata/libata-core.c:1622): Excess function parameter or struct member 'fn' description in 'ata_pio_queue_task'
Warning(drivers/ata/libata-core.c:4655): Excess function parameter or struct member 'err_mask' description in 'ata_qc_complete'
Warning(drivers/ata/ata_piix.c:751): Excess function parameter or struct member 'udma' description in 'do_pata_set_dmamode'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/ata/ata_piix.c | 1 -
drivers/ata/libata-core.c | 2 --
2 files changed, 3 deletions(-)
--- lin2628-rc2.orig/drivers/ata/ata_piix.c
+++ lin2628-rc2/drivers/ata/ata_piix.c
@@ -738,7 +738,6 @@ static void piix_set_piomode(struct ata_
* do_pata_set_dmamode - Initialize host controller PATA PIO timings
* @ap: Port whose timings we are configuring
* @adev: Drive in question
- * @udma: udma mode, 0 - 6
* @isich: set if the chip is an ICH device
*
* Set UDMA mode for device, in host controller PCI config space.
--- lin2628-rc2.orig/drivers/ata/libata-core.c
+++ lin2628-rc2/drivers/ata/libata-core.c
@@ -1602,7 +1602,6 @@ unsigned long ata_id_xfermask(const u16
/**
* ata_pio_queue_task - Queue port_task
* @ap: The ata_port to queue port_task for
- * @fn: workqueue function to be scheduled
* @data: data for @fn to use
* @delay: delay time in msecs for workqueue function
*
@@ -4643,7 +4642,6 @@ static void ata_verify_xfer(struct ata_q
/**
* ata_qc_complete - Complete an active ATA command
* @qc: Command to complete
- * @err_mask: ATA Status register contents
*
* Indicate to the mid and upper layers that an ATA
* command has completed, with either an ok or not-ok status.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 5/7] ATA: remove excess kernel-doc notation
2008-10-30 5:35 [PATCH 5/7] ATA: remove excess kernel-doc notation Randy Dunlap
@ 2008-10-31 5:45 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-10-31 5:45 UTC (permalink / raw)
To: Randy Dunlap; +Cc: ide, akpm
Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Remove excess kernel-doc function parameter notation from drivers/ata/:
>
> Warning(drivers/ata/libata-core.c:1622): Excess function parameter or struct member 'fn' description in 'ata_pio_queue_task'
> Warning(drivers/ata/libata-core.c:4655): Excess function parameter or struct member 'err_mask' description in 'ata_qc_complete'
> Warning(drivers/ata/ata_piix.c:751): Excess function parameter or struct member 'udma' description in 'do_pata_set_dmamode'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/ata/ata_piix.c | 1 -
> drivers/ata/libata-core.c | 2 --
> 2 files changed, 3 deletions(-)
>
> --- lin2628-rc2.orig/drivers/ata/ata_piix.c
> +++ lin2628-rc2/drivers/ata/ata_piix.c
> @@ -738,7 +738,6 @@ static void piix_set_piomode(struct ata_
> * do_pata_set_dmamode - Initialize host controller PATA PIO timings
> * @ap: Port whose timings we are configuring
> * @adev: Drive in question
> - * @udma: udma mode, 0 - 6
> * @isich: set if the chip is an ICH device
> *
> * Set UDMA mode for device, in host controller PCI config space.
> --- lin2628-rc2.orig/drivers/ata/libata-core.c
> +++ lin2628-rc2/drivers/ata/libata-core.c
> @@ -1602,7 +1602,6 @@ unsigned long ata_id_xfermask(const u16
> /**
> * ata_pio_queue_task - Queue port_task
> * @ap: The ata_port to queue port_task for
> - * @fn: workqueue function to be scheduled
> * @data: data for @fn to use
> * @delay: delay time in msecs for workqueue function
> *
> @@ -4643,7 +4642,6 @@ static void ata_verify_xfer(struct ata_q
> /**
> * ata_qc_complete - Complete an active ATA command
> * @qc: Command to complete
> - * @err_mask: ATA Status register contents
> *
> * Indicate to the mid and upper layers that an ATA
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-31 5:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-30 5:35 [PATCH 5/7] ATA: remove excess kernel-doc notation Randy Dunlap
2008-10-31 5:45 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).