linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: petkovbb@gmail.com, Tejun Heo <tj@kernel.org>,
	axboe@kernel.dk, bzolnier@gmail.com, linux-ide@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] ide-floppy partitions
Date: Tue, 04 Nov 2008 00:37:42 +0900	[thread overview]
Message-ID: <490F1AC6.8000109@kernel.org> (raw)
In-Reply-To: <20081101201419.GA29462@gollum.tnic>

Borislav Petkov wrote:
> can you guys please ACK/NACK this so that we can have an agreed upon solution
> and so that I can stop applying it ontop of current git before testing any
> further.

Ah... right.  I missed removable devices.  I think it would be better to
just expand the table rather than recursing into __blkdev_get() again.
I'll try to come up with cleaner solution.  Also, I don't think the
discontinuous partition would be a problem.  ptbl is expanded to the
highest numbered partition not the number of partitions.  I'll test that
too.  Thanks.

-- 
tejun

  reply	other threads:[~2008-11-03 15:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-29  7:13 [RFC PATCH] ide-floppy partitions Borislav Petkov
2008-10-29  7:42 ` [PATCH] ide-gd: re-get floppy capacity on revalidate Borislav Petkov
2008-10-29 19:22   ` Bartlomiej Zolnierkiewicz
2008-11-01 20:14 ` [RFC PATCH] ide-floppy partitions Borislav Petkov
2008-11-03 15:37   ` Tejun Heo [this message]
2008-11-03 17:56     ` Borislav Petkov
2008-11-04  4:16       ` Subject: [PATCH] block: fix __blkdev_get() for removable devices Tejun Heo
2008-11-05  9:04         ` Borislav Petkov
2008-11-05  9:19           ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=490F1AC6.8000109@kernel.org \
    --to=tj@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petkovbb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).