linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Phil Sutter <n0-1@freewrt.org>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	linux-ide@vger.kernel.org
Subject: Re: [PATCH] pata-rb532-cf: read and write data in 4-byte blocks
Date: Tue, 04 Nov 2008 01:01:25 -0500	[thread overview]
Message-ID: <490FE535.8080109@garzik.org> (raw)
In-Reply-To: <1225718954-8307-1-git-send-email-n0-1@freewrt.org>

Phil Sutter wrote:
> * rename the offset definition to avoid abiguity with the standard ATA
>   IO address
> * read and write four bytes at once
> * use writesl() and readsl() which implicitly iterate over the data
> * fix the signature of rb532_pata_data_xfer() to match the function
>   pointer definition and return the number of bytes consumed
> 
> Signed-off-by: Phil Sutter <n0-1@freewrt.org>
> Acked-by: Sergei Shtyltov <sshtylyov@ru.mvista.com>
> ---
>  drivers/ata/pata_rb532_cf.c |   21 ++++++++++-----------
>  1 files changed, 10 insertions(+), 11 deletions(-)

None of this description says _why_ you wish to do this.  Also, maybe I 
missed the response, what about ATAPI?

	Jeff




  parent reply	other threads:[~2008-11-04  6:01 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-30 21:47 [PATCH] fix pata-rb532-cf Phil Sutter
2008-10-30 22:39 ` Florian Fainelli
2008-10-30 23:20 ` Sergei Shtylyov
2008-10-31  0:09   ` Phil Sutter
2008-10-31 10:38     ` Sergei Shtylyov
2008-10-31 11:08       ` Sergei Shtylyov
2008-11-01 16:09       ` Phil Sutter
2008-11-01 16:12         ` Phil Sutter
2008-11-01 16:26           ` Sergei Shtylyov
2008-11-01 16:45             ` Sergei Shtylyov
2008-11-01 16:45             ` Phil Sutter
2008-11-01 18:09               ` Phil Sutter
2008-11-01 18:11                 ` [PATCH] read and write data in 4-byte blocks Phil Sutter
2008-11-01 18:21                   ` Phil Sutter
2008-11-02 21:23                     ` Sergei Shtylyov
2008-11-03 13:29                       ` [PATCH] pata-rb532-cf: " Phil Sutter
2008-11-03 13:45                         ` Bartlomiej Zolnierkiewicz
2008-11-04  6:01                         ` Jeff Garzik [this message]
2008-11-04 12:35                           ` Phil Sutter
2008-11-05 11:54                             ` Sergei Shtylyov
2008-11-05 12:52                               ` Phil Sutter
2008-11-02 22:04                 ` [PATCH] fix pata-rb532-cf Sergei Shtylyov
2008-11-02 22:45                   ` Phil Sutter
2008-11-01 16:16         ` Sergei Shtylyov
2008-11-12  0:13 ` Phil Sutter
2008-11-12  0:13   ` [PATCH] pata-rb532-cf: read/write data in 4-byte blocks Phil Sutter
2008-11-12  0:14     ` [PATCH] pata-rb532-cf: fix signature of the xfer function Phil Sutter
2008-11-12  2:26       ` Florian Fainelli
2008-11-12 10:54       ` Sergei Shtylyov
2008-11-12  2:25     ` [PATCH] pata-rb532-cf: read/write data in 4-byte blocks Florian Fainelli
2008-11-12 10:50     ` Sergei Shtylyov
2008-11-12 20:57   ` [PATCH] fix pata-rb532-cf Bartlomiej Zolnierkiewicz
2008-11-14 23:53   ` Jeff Garzik
2009-01-11 16:13     ` Florian Fainelli
2009-01-11 20:47       ` Phil Sutter
2009-01-12 14:32         ` Florian Fainelli
2009-01-12 17:48           ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=490FE535.8080109@garzik.org \
    --to=jeff@garzik.org \
    --cc=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=n0-1@freewrt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).