From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org, Elias Oltmanns <eo@nebensachen.de>
Subject: Re: [PATCH 7/8] libata: Fix a potential race condition in ata_scsi_park_show()
Date: Tue, 04 Nov 2008 01:10:54 -0500 [thread overview]
Message-ID: <490FE76E.1050007@garzik.org> (raw)
In-Reply-To: <1225706469-27870-8-git-send-email-tj@kernel.org>
Tejun Heo wrote:
> From: Elias Oltmanns <eo@nebensachen.de>
>
> Peter Moulder has pointed out that there is a slight chance that a
> negative value might be passed to jiffies_to_msecs() in
> ata_scsi_park_show(). This is fixed by saving the value of jiffies in a
> local variable, thus also reducing code since the volatile variable
> jiffies is accessed only once.
>
> Signed-off-by: Elias Oltmanns <eo@nebensachen.de>
> Signed-off-by: Tejun Heo <tj.kernel.org>
> ---
> drivers/ata/libata-scsi.c | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
applied
next prev parent reply other threads:[~2008-11-04 6:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-03 10:01 [PATCHSET #upstream-fixes] patches which fell off the crack during maintainership handover Tejun Heo
2008-11-03 10:01 ` [PATCH 1/8] Hibernation: Introduce system_entering_hibernation Tejun Heo
2008-11-04 6:14 ` Jeff Garzik
2008-11-03 10:01 ` [PATCH 2/8] DMI: Introduce dmi_first_match to make the interface more flexible Tejun Heo
2008-11-03 10:01 ` [PATCH 3/8] SATA: Blacklisting of systems that spin off disks during ACPI power off (rev. 2) Tejun Heo
2008-11-03 10:01 ` [PATCH 4/8] SATA AHCI: Blacklist system that spins off disks during ACPI power off Tejun Heo
2008-11-03 10:01 ` [PATCH 5/8] SATA Sil: " Tejun Heo
2008-11-03 10:01 ` [PATCH 6/8] SATA PIIX: " Tejun Heo
2008-11-03 10:01 ` [PATCH 7/8] libata: Fix a potential race condition in ata_scsi_park_show() Tejun Heo
2008-11-04 6:10 ` Jeff Garzik [this message]
2008-11-03 10:01 ` [PATCH 8/8] libata: implement ATA_HORKAGE_ATAPI_MOD16_DMA and apply it Tejun Heo
2008-11-04 6:11 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490FE76E.1050007@garzik.org \
--to=jeff@garzik.org \
--cc=eo@nebensachen.de \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).