From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH #upstream-fixes] libata: mask off DET when restoring SControl for detach
Date: Tue, 04 Nov 2008 01:11:11 -0500 [thread overview]
Message-ID: <490FE77F.8020600@garzik.org> (raw)
In-Reply-To: <490ED1FB.9080505@kernel.org>
Tejun Heo wrote:
> libata restores SControl on detach; however, trying to restore
> non-zero DET can cause undeterministic behavior including PMP device
> going offline till power cycling. Mask off DET when restoring
> SControl.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> ---
> drivers/ata/libata-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: work/drivers/ata/libata-core.c
> ===================================================================
> --- work.orig/drivers/ata/libata-core.c
> +++ work/drivers/ata/libata-core.c
> @@ -5936,7 +5936,7 @@ static void ata_port_detach(struct ata_p
> * to us. Restore SControl and disable all existing devices.
> */
> __ata_port_for_each_link(link, ap) {
> - sata_scr_write(link, SCR_CONTROL, link->saved_scontrol);
> + sata_scr_write(link, SCR_CONTROL, link->saved_scontrol & 0xff0);
> ata_link_for_each_dev(dev, link)
> ata_dev_disable(dev);
applied
prev parent reply other threads:[~2008-11-04 6:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-03 10:27 [PATCH #upstream-fixes] libata: mask off DET when restoring SControl for detach Tejun Heo
2008-11-04 6:11 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490FE77F.8020600@garzik.org \
--to=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).