From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 3/6] rz1000: apply chipset quirks early Date: Tue, 04 Nov 2008 20:18:33 +0300 Message-ID: <491083E9.60305@ru.mvista.com> References: <20081103200244.5098.29817.sendpatchset@localhost.localdomain> <20081103200306.5098.41565.sendpatchset@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from gateway-1237.mvista.com ([63.81.120.155]:46713 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753560AbYKDRSj (ORCPT ); Tue, 4 Nov 2008 12:18:39 -0500 In-Reply-To: <20081103200306.5098.41565.sendpatchset@localhost.localdomain> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Hello. Bartlomiej Zolnierkiewicz wrote: > From: Bartlomiej Zolnierkiewicz > Subject: [PATCH] rz1000: apply chipset quirks early > * Use pci_name(dev) instead of hwif->name in init_hwif_rz1000(). > * init_hwif_rz1000() -> rz1000_init_chipset(). Update rz1000_init_one() > to use rz1000_init_chipset() and add now required rz1000_remove(). > * Remove superfluous ide_rz1000 chipset type. > Signed-off-by: Bartlomiej Zolnierkiewicz > Index: b/drivers/ide/rz1000.c > =================================================================== > --- a/drivers/ide/rz1000.c > +++ b/drivers/ide/rz1000.c > @@ -22,34 +22,48 @@ > > #define DRV_NAME "rz1000" > > -static void __devinit init_hwif_rz1000 (ide_hwif_t *hwif) > +static unsigned int __devinit rz1000_init_chipset(struct pci_dev *dev) Hm, this is not a real init_chipset() method and it does just one thing -- disables readahead, so rz1000_disable_readahead() or something of that sort seems like a better name... MBR, Sergei