Re: [PATCH 6/6] ide: rework handling of serialized ports

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello, I wrote:

>> Index: b/drivers/ide/ide-probe.c
>> ===================================================================
>> --- a/drivers/ide/ide-probe.c
>> +++ b/drivers/ide/ide-probe.c

> [...]

>> @@ -1436,10 +1398,8 @@ static void ide_init_port(ide_hwif_t *hw
>>      }
>>  
>>      if ((d->host_flags & IDE_HFLAG_SERIALIZE) ||
>> -        ((d->host_flags & IDE_HFLAG_SERIALIZE_DMA) && hwif->dma_base)) {
>> -        if (hwif->mate)
>> -            hwif->mate->serialized = hwif->serialized = 1;
>> -    }
>> +        ((d->host_flags & IDE_HFLAG_SERIALIZE_DMA) && hwif->dma_base))
>> +        hwif->host_flags |= IDE_HFLAG_SERIALIZE;

>    I don't see what use is forcing this flag at all here -- it doesn't 
> seem to be checked only in init_irq() now, so this *if* could just be 
> moved there...

    Oops, rephrasing hurts sometimes: I meant "it seems", of course. :-)

MBR, Sergei