From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] rz1000: apply chipset quirks early
Date: Tue, 04 Nov 2008 21:56:09 +0300 [thread overview]
Message-ID: <49109AC9.5090406@ru.mvista.com> (raw)
In-Reply-To: <491083E9.60305@ru.mvista.com>
Hello, I wrote:
>> Index: b/drivers/ide/rz1000.c
>> ===================================================================
>> --- a/drivers/ide/rz1000.c
>> +++ b/drivers/ide/rz1000.c
>> @@ -22,34 +22,48 @@
>>
>> #define DRV_NAME "rz1000"
>>
>> -static void __devinit init_hwif_rz1000 (ide_hwif_t *hwif)
>> +static unsigned int __devinit rz1000_init_chipset(struct pci_dev *dev)
> Hm, this is not a real init_chipset() method and it does just one
> thing -- disables readahead, so rz1000_disable_readahead() or something
> of that sort seems like a better name...
Hm, 'unsigned' result type wasn't terribly helpful here as well. :-)
MBR, Sergei
next prev parent reply other threads:[~2008-11-04 18:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-03 20:02 [PATCH 1/6] ide: fix ->quirk_list checking in ide_do_request() Bartlomiej Zolnierkiewicz
2008-11-03 20:02 ` [PATCH 2/6] ide: always set nIEN on idle devices Bartlomiej Zolnierkiewicz
2008-11-03 20:03 ` [PATCH 3/6] rz1000: apply chipset quirks early Bartlomiej Zolnierkiewicz
2008-11-04 17:18 ` Sergei Shtylyov
2008-11-04 18:56 ` Sergei Shtylyov [this message]
2008-11-09 14:03 ` Bartlomiej Zolnierkiewicz
2008-11-03 20:03 ` [PATCH 4/6] trm290: add IDE_HFLAG_TRM290 host flag Bartlomiej Zolnierkiewicz
2008-11-04 17:36 ` Sergei Shtylyov
2008-11-03 20:03 ` [PATCH 5/6] cy82c693: remove superfluous ide_cy82c693 chipset type Bartlomiej Zolnierkiewicz
2008-11-03 20:03 ` [PATCH 6/6] ide: rework handling of serialized ports Bartlomiej Zolnierkiewicz
2008-11-04 18:30 ` Sergei Shtylyov
2008-11-04 18:34 ` Sergei Shtylyov
2008-11-09 14:04 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49109AC9.5090406@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).