[PATCH 5/5] storage-fixup: a Makefile

[PATCH 5/5] storage-fixup: a Makefile

[Kel Modderman]

Add a Makefile for convenience of installation and preparing dist. tarball.

This could be handy for distributions/admins who want to deploy this workaround
in a package.

Signed-off-by: Kel Modderman <kel@otaku42.de>
---
--- /dev/null
+++ b/Makefile
@@ -0,0 +1,33 @@
+#!/usr/bin/make -f
+
+NAME    := storage-fixup
+FILES   := $(NAME) $(NAME).conf $(NAME).8 LICENSE Makefile
+VERSION := $(shell /bin/bash ./$(NAME) -V)
+BINDIR  := /usr/sbin
+ETCDIR  := /etc
+MANDIR  := /usr/share/man/man8
+MKDIR   := mkdir -p
+INSTALL := install
+
+all:
+	$(info Nothing to be done, ready for "$(MAKE) install" ...)
+
+%.gz: %
+	gzip -9 < $< > $@
+
+install: $(NAME).8.gz
+	$(MKDIR) $(DESTDIR)$(BINDIR)
+	$(INSTALL) -t $(DESTDIR)$(BINDIR) -m 755 $(NAME)
+	$(MKDIR) $(DESTDIR)$(ETCDIR)
+	$(INSTALL) -t $(DESTDIR)$(ETCDIR) -m 644 $(NAME).conf
+	$(MKDIR) $(DESTDIR)$(MANDIR)
+	$(INSTALL) -t $(DESTDIR)$(MANDIR) -m 644 $(NAME).8.gz
+
+clean:
+	$(RM) $(NAME).8.gz
+
+dist: clean
+	git-archive --format=tar --prefix=$(NAME)-$(VERSION)/ HEAD \
+		$(FILES) | tar -C.. -xf -
+	tar -czvf ../$(NAME)-$(VERSION).tar.gz -C.. $(NAME)-$(VERSION)/
+	$(RM) -r ../$(NAME)-$(VERSION)/
---

Re: [PATCH 5/5] storage-fixup: a Makefile

[Tejun Heo]

Kel Modderman wrote:
> +dist: clean
> +	git-archive --format=tar --prefix=$(NAME)-$(VERSION)/ HEAD \
> +		$(FILES) | tar -C.. -xf -
> +	tar -czvf ../$(NAME)-$(VERSION).tar.gz -C.. $(NAME)-$(VERSION)/
> +	$(RM) -r ../$(NAME)-$(VERSION)/

Why untar and tar again?

-- 
tejun

Re: [PATCH 5/5] storage-fixup: a Makefile

[Kel Modderman]

On Wednesday 12 November 2008 15:28:31 Tejun Heo wrote:
> Kel Modderman wrote:
> > +dist: clean
> > +	git-archive --format=tar --prefix=$(NAME)-$(VERSION)/ HEAD \
> > +		$(FILES) | tar -C.. -xf -
> > +	tar -czvf ../$(NAME)-$(VERSION).tar.gz -C.. $(NAME)-$(VERSION)/
> > +	$(RM) -r ../$(NAME)-$(VERSION)/
> 
> Why untar and tar again?
> 

Don't have a reason. This is probably better:
---
dist: clean
	git-archive --format=tar --prefix=$(NAME)-$(VERSION)/ HEAD \
		$(FILES) | gzip > ../$(NAME)-$(VERSION).tar.gz
---

Thanks, Kel.

Re: [PATCH 5/5] storage-fixup: a Makefile

[Tejun Heo]

Kel Modderman wrote:
> On Wednesday 12 November 2008 15:28:31 Tejun Heo wrote:
>> Kel Modderman wrote:
>>> +dist: clean
>>> +	git-archive --format=tar --prefix=$(NAME)-$(VERSION)/ HEAD \
>>> +		$(FILES) | tar -C.. -xf -
>>> +	tar -czvf ../$(NAME)-$(VERSION).tar.gz -C.. $(NAME)-$(VERSION)/
>>> +	$(RM) -r ../$(NAME)-$(VERSION)/
>> Why untar and tar again?
>>
> 
> Don't have a reason. This is probably better:
> ---
> dist: clean
> 	git-archive --format=tar --prefix=$(NAME)-$(VERSION)/ HEAD \
> 		$(FILES) | gzip > ../$(NAME)-$(VERSION).tar.gz

Updated to create tarball in the source directory as you never know
you'll have write access to .. && git-archive doesn't mind having extra
files lying around anyway.

Thanks.

-- 
tejun