* [PATCH 1/7] drivers/ata/pata_radisys.c: cleanup kernel-doc
@ 2008-11-16 9:43 Qinghuang Feng
2008-11-17 17:43 ` Randy Dunlap
2008-11-25 16:39 ` Jeff Garzik
0 siblings, 2 replies; 4+ messages in thread
From: Qinghuang Feng @ 2008-11-16 9:43 UTC (permalink / raw)
To: linux-kernel; +Cc: qhfeng.kernel, Randy Dunlap, Jeff Garzik, linux-ide
No argument named @isich in radisys_set_dmamode,
remove it.
Signed-off-by: Qinghuang Feng <qhfeng.kernel@gmail.com>
---
diff --git a/drivers/ata/pata_radisys.c b/drivers/ata/pata_radisys.c
index 0b0aa45..695d44a 100644
--- a/drivers/ata/pata_radisys.c
+++ b/drivers/ata/pata_radisys.c
@@ -81,7 +81,6 @@ static void radisys_set_piomode (struct ata_port *ap, struct ata_device *adev)
* radisys_set_dmamode - Initialize host controller PATA DMA timings
* @ap: Port whose timings we are configuring
* @adev: Device to program
- * @isich: True if the device is an ICH and has IOCFG registers
*
* Set MWDMA mode for device, in host controller PCI config space.
*
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/7] drivers/ata/pata_radisys.c: cleanup kernel-doc
2008-11-16 9:43 [PATCH 1/7] drivers/ata/pata_radisys.c: cleanup kernel-doc Qinghuang Feng
@ 2008-11-17 17:43 ` Randy Dunlap
2008-11-25 16:39 ` Jeff Garzik
1 sibling, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2008-11-17 17:43 UTC (permalink / raw)
To: Qinghuang Feng; +Cc: linux-kernel, Randy Dunlap, Jeff Garzik, linux-ide
On Sun, 16 Nov 2008 17:43:46 +0800 Qinghuang Feng wrote:
> No argument named @isich in radisys_set_dmamode,
> remove it.
>
> Signed-off-by: Qinghuang Feng <qhfeng.kernel@gmail.com>
patches 1-7:
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
I'll leave them for Jeff to merge.
Thanks.
---
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/7] drivers/ata/pata_radisys.c: cleanup kernel-doc
2008-11-16 9:43 [PATCH 1/7] drivers/ata/pata_radisys.c: cleanup kernel-doc Qinghuang Feng
2008-11-17 17:43 ` Randy Dunlap
@ 2008-11-25 16:39 ` Jeff Garzik
2008-11-25 17:00 ` sniper
1 sibling, 1 reply; 4+ messages in thread
From: Jeff Garzik @ 2008-11-25 16:39 UTC (permalink / raw)
To: Qinghuang Feng; +Cc: linux-kernel, Randy Dunlap, linux-ide
Qinghuang Feng wrote:
> No argument named @isich in radisys_set_dmamode,
> remove it.
>
> Signed-off-by: Qinghuang Feng <qhfeng.kernel@gmail.com>
> ---
> diff --git a/drivers/ata/pata_radisys.c b/drivers/ata/pata_radisys.c
> index 0b0aa45..695d44a 100644
> --- a/drivers/ata/pata_radisys.c
> +++ b/drivers/ata/pata_radisys.c
> @@ -81,7 +81,6 @@ static void radisys_set_piomode (struct ata_port *ap, struct ata_device *adev)
> * radisys_set_dmamode - Initialize host controller PATA DMA timings
> * @ap: Port whose timings we are configuring
> * @adev: Device to program
> - * @isich: True if the device is an ICH and has IOCFG registers
> *
> * Set MWDMA mode for device, in host controller PCI config space.
> *
applied 1-7 to #upstream, after combining into a single patch. I felt a
single changeset was more appropriate.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-11-25 17:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-16 9:43 [PATCH 1/7] drivers/ata/pata_radisys.c: cleanup kernel-doc Qinghuang Feng
2008-11-17 17:43 ` Randy Dunlap
2008-11-25 16:39 ` Jeff Garzik
2008-11-25 17:00 ` sniper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).