From: Tejun Heo <tj@kernel.org>
To: Kel Modderman <kel@otaku42.de>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 5/5] storage-fixup: a Makefile
Date: Mon, 17 Nov 2008 11:18:30 +0900 [thread overview]
Message-ID: <4920D476.1060101@kernel.org> (raw)
In-Reply-To: <200811170343.59740.kel@otaku42.de>
Kel Modderman wrote:
> On Wednesday 12 November 2008 15:28:31 Tejun Heo wrote:
>> Kel Modderman wrote:
>>> +dist: clean
>>> + git-archive --format=tar --prefix=$(NAME)-$(VERSION)/ HEAD \
>>> + $(FILES) | tar -C.. -xf -
>>> + tar -czvf ../$(NAME)-$(VERSION).tar.gz -C.. $(NAME)-$(VERSION)/
>>> + $(RM) -r ../$(NAME)-$(VERSION)/
>> Why untar and tar again?
>>
>
> Don't have a reason. This is probably better:
> ---
> dist: clean
> git-archive --format=tar --prefix=$(NAME)-$(VERSION)/ HEAD \
> $(FILES) | gzip > ../$(NAME)-$(VERSION).tar.gz
Updated to create tarball in the source directory as you never know
you'll have write access to .. && git-archive doesn't mind having extra
files lying around anyway.
Thanks.
--
tejun
prev parent reply other threads:[~2008-11-17 2:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 23:11 [PATCH 5/5] storage-fixup: a Makefile Kel Modderman
2008-11-12 5:28 ` Tejun Heo
2008-11-16 17:43 ` Kel Modderman
2008-11-17 2:18 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4920D476.1060101@kernel.org \
--to=tj@kernel.org \
--cc=kel@otaku42.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).