Re: [PATCH] Withdraw IGN_SERR_INTERNAL for SB800 SATA

[Tejun Heo <htejun@gmail.com>]

Huang, Shane wrote:
> Hi Tejun,
>  
> 
>> -----Original Message-----
>> From: Tejun Heo [mailto:htejun@gmail.com] 
>>>  
>>> +	/* SB800 does NOT need the workaround to ignore SERR_INTERNAL */
>>> +	if (board_id == board_ahci_sb700 && pdev->revision >= 0x40)
>>> +		hpriv->flags &= ~AHCI_HFLAG_IGN_SERR_INTERNAL;
>>> +
>>>  	if ((hpriv->flags & AHCI_HFLAG_NO_MSI) || pci_enable_msi(pdev))
>>>  		pci_intx(pdev, 1);
>> Great, but please use separate board_ahci_* entry.  ie.
>> board_ahci_sb700_ign_serr for the ones with the problem and
>> board_ahci_sb700 for other sb700s and sb800s.
> 
> Thanks for your suggestion.
> 
> Different SATA controller revisions with/without the problem have SAME
> PCI device ID,
> so it's difficult to distinguish them with board_ahci_sb700_ign_serr and
> board_ahci_sb700 at the beginning.
> 
> Although we can distinguish them in ahci_init_one() and reevaluate
> board_id
> as well as ent->driver_data, I still suggest we keep my submitted patch
> because it seems to be neater. :-)
> 
> And I also added some comments for better maintainance like
> /* board_ahci_sb700, for SB700 and SB800 */
> /* SB800 does NOT need the workaround to ignore SERR_INTERNAL */
> It should be much clear to us now...

Ah.. right, can't match revision.  Yeap, then,

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun