From: Tejun Heo <teheo@suse.de>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dwmw2@infradead.org, Nick Piggin <npiggin@suse.de>,
Jens Axboe <jens.axboe@oracle.com>,
IDE/ATA development list <linux-ide@v>
Cc: Matthew Wilcox <matthew@wil.cx>
Subject: Re: about TRIM/DISCARD support and barriers
Date: Sun, 23 Nov 2008 16:57:31 +0900 [thread overview]
Message-ID: <49290CEB.7070509@suse.de> (raw)
In-Reply-To: <4929023C.2060302@suse.de>
Tejun Heo wrote:
> Dongjun, the only doc I can find about ATA TRIM is the following one.
>
> http://t13.org/Documents/UploadedDocuments/docs2007/e07154r3-Data_Set_Management_Proposal_for_ATA-ACS2.pdf
>
> And AFAICS this hasn't made into ACS yet. Is this what you guys are
> gonna implement and Windows7 is gonna use?
Just went over it. Matthew, if ATA trim is gonna be implemented as
described in the above document, it will support multiple ranges per
command.
Dongjun, the above document strikes out all the latency/performance
related stuff, which looks like the right move to me. Most of those
information can be extracted from access pattern by the device itself
and exposing such optimization parameters to outside seldom works well.
I'm fairly sure such over complexity will end up being
counter-optimization due to different interpretations and executions by
different parties (be it harddrive vendors or different filesystems).
So, can you please confirm that, what we eventually get is simple TRIM
w/ multiple ranges? Which, BTW, makes sense as it's something the
device can't infer from the access pattern. Also, if there still is
wiggle room, what would be a worthy optimization is to allow TRIM
commands to be sent together with other NCQ commands as otherwise the
drive will have to drain all other commands to process a TRIM command
which will be inefficient.
Thanks.
--
tejun
next prev parent reply other threads:[~2008-11-23 7:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-23 4:46 about TRIM/DISCARD support and barriers Tejun Heo
2008-11-23 7:11 ` Tejun Heo
2008-11-23 7:57 ` Tejun Heo [this message]
2008-11-24 5:40 ` Dongjun Shin
2008-11-24 5:45 ` Tejun Heo
2008-11-24 5:57 ` James Bottomley
2008-11-23 12:35 ` Matthew Wilcox
2008-11-23 13:39 ` David Woodhouse
2008-11-23 22:52 ` James Bottomley
2008-11-24 9:03 ` David Woodhouse
2008-11-24 18:42 ` James Bottomley
2008-11-24 18:52 ` David Woodhouse
2008-11-24 18:57 ` Jens Axboe
2008-11-24 19:08 ` James Bottomley
2008-11-25 9:16 ` Jens Axboe
2008-11-24 19:09 ` James Bottomley
2008-11-25 3:28 ` Matthew Wilcox
2008-11-25 9:15 ` Jens Axboe
2008-11-24 3:01 ` Theodore Tso
2008-11-28 13:21 ` Raz Ben-Yehuda
2008-11-29 22:57 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49290CEB.7070509@suse.de \
--to=teheo@suse.de \
--cc=dwmw2@infradead.org \
--cc=jens.axboe@oracle.com \
--cc=linux-ide@v \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).