From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Chad Reese <kreese@caviumnetworks.com>
Cc: David Daney <ddaney@caviumnetworks.com>,
linux-ide@vger.kernel.org, linux-mips <linux-mips@linux-mips.org>
Subject: Re: [PATCH] ide: New libata driver for OCTEON SOC Compact Flash interface.
Date: Sun, 23 Nov 2008 20:10:42 +0300 [thread overview]
Message-ID: <49298E92.9070605@ru.mvista.com> (raw)
In-Reply-To: <492975B9.2000807@ru.mvista.com>
Hello, I wrote:
>>> + * stoppng and restarting the DMA, we'll let the hardware do
>>> it. If the
>>
>> stopping
>>
>>> + * DMA is really stopped early due to an error condition, a later
>
> I'm not sure which error condition is meant here: ERR=1 in the
> status register, some internal DMA error, both?
>
>>> + * timeout will force us to stop.
>>
>> Sigh... So any command error will result in a timeout. I wonder
>> what hardware genius decided that CF doesn't need an IRQ...
Ah, I forgot thet libata should be supporting polling mode, so should
handle ERR=1 case. In this case the comment about the timeout
contradicts your words about an interrupt being generated on DMA error.
> So, Octeon DMA can actually generate an error interrupt?
MBR, Sergei
next prev parent reply other threads:[~2008-11-23 17:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 2:24 [PATCH] ide: New libata driver for OCTEON SOC Compact Flash interface David Daney
2008-11-21 10:21 ` Alan Cox
2008-11-21 17:05 ` David Daney
2008-11-21 17:26 ` Sergei Shtylyov
2008-11-21 17:47 ` David Daney
2008-11-21 18:07 ` Alan Cox
2008-11-21 17:49 ` Alan Cox
2008-11-21 16:40 ` Sergei Shtylyov
2008-11-21 17:29 ` David Daney
2008-11-21 18:14 ` Sergei Shtylyov
2008-11-21 18:43 ` Chad Reese
2008-11-21 17:46 ` Alan Cox
2008-11-21 17:37 ` Sergei Shtylyov
2008-11-21 18:12 ` Alan Cox
2008-11-22 13:57 ` Sergei Shtylyov
2008-11-22 14:52 ` Alan Cox
2008-11-22 15:05 ` Sergei Shtylyov
2008-11-23 17:14 ` Sergei Shtylyov
2008-11-24 20:40 ` David Daney
2008-11-24 22:33 ` Sergei Shtylyov
2008-11-22 15:13 ` Sergei Shtylyov
2008-11-22 18:38 ` Chad Reese
2008-11-23 15:13 ` Sergei Shtylyov
2008-11-23 15:24 ` Sergei Shtylyov
2008-11-23 17:10 ` Sergei Shtylyov [this message]
2008-11-23 17:32 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49298E92.9070605@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=ddaney@caviumnetworks.com \
--cc=kreese@caviumnetworks.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).