From: Tejun Heo <tj@kernel.org>
To: Robert Hancock <hancockr@shaw.ca>
Cc: David Daney <ddaney@caviumnetworks.com>,
IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] ata: Remove inline attribute from ata_sff_host_intr()
Date: Mon, 24 Nov 2008 14:49:01 +0900 [thread overview]
Message-ID: <492A404D.1010107@kernel.org> (raw)
In-Reply-To: <492A3EB2.8070504@shaw.ca>
Robert Hancock wrote:
> Tejun Heo wrote:
>> David Daney wrote:
>>> ata: Remove inline attribute from ata_sff_host_intr()
>>>
>>> ata_sff_host_intr is a public function, it should not be declared
>>> inline.
>>
>> Why not?
>>
>
> Well, it's a bit unusual to have a non-static inline (an exported symbol
> no less) in a C file.. how could any callers outside the file ever
> actually inline it? Aside from that it seems a bit big for inlining..
The goal there is to inline ata_sff_host_intr() into ata_sff_interrupt()
and then export a separate copy to other users as ata_sff_interrupt() is
very hot. Looking at the disassembly, gcc is doing what it's told to
do, so the inline actually is doing something useful there.
Thanks.
--
tejun
next prev parent reply other threads:[~2008-11-24 5:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 0:39 [PATCH] ata: Remove inline attribute from ata_sff_host_intr() David Daney
2008-11-24 5:20 ` Tejun Heo
2008-11-24 5:42 ` Robert Hancock
2008-11-24 5:49 ` Tejun Heo [this message]
2008-11-24 17:21 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492A404D.1010107@kernel.org \
--to=tj@kernel.org \
--cc=ddaney@caviumnetworks.com \
--cc=hancockr@shaw.ca \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).