From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: kai@kaishome.de, linux-ide@vger.kernel.org
Subject: Re: [PATCH] pata_sis: Remove bogus cable match
Date: Fri, 05 Dec 2008 15:31:40 -0500 [thread overview]
Message-ID: <49398FAC.2060301@garzik.org> (raw)
In-Reply-To: <20081205194117.17036.74479.stgit@localhost.localdomain>
Alan Cox wrote:
> From: Alan Cox <alan@redhat.com>
>
> Some systems report SIS 5513 as both vendor/id and subvendor/id string. In
> that case we can't distinguish the system by the id svid/sdid and in fact
> the entry here breaks some boxes. At some point we need to find another way
> to detect the Targa Visionary 1000, until then this a hang for some users with
> lower performance for others.
>
> Closes: #12092
>
> Signed-off-by: Alan Cox <alan@redhat.com>
Should that last sentence be "this SOLVES a hang"?
As it is currently worded, it is unclear what we are trading off with
this patch...
Thanks,
Jeff
next prev parent reply other threads:[~2008-12-05 20:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 19:41 [PATCH] pata_sis: Remove bogus cable match Alan Cox
2008-12-05 20:31 ` Jeff Garzik [this message]
2008-12-06 0:27 ` Alan Cox
2008-12-08 11:13 ` Kai Krakow
2008-12-08 11:39 ` Alan Cox
2008-12-09 5:48 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49398FAC.2060301@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=kai@kaishome.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).