From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: David Daney <ddaney@caviumnetworks.com>
Cc: linux-ide@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH 1/3] libata: Add another column to the ata_timing table.
Date: Thu, 11 Dec 2008 02:52:32 +0300 [thread overview]
Message-ID: <49405640.4020205@ru.mvista.com> (raw)
In-Reply-To: <1228952353-12323-1-git-send-email-ddaney@caviumnetworks.com>
Hello.
David Daney wrote:
> The forthcoming OCTEON SOC Compact Flash driver needs an additional
> timing value that was not available in the ata_timing table. I add a
> new column for dmack_hold time. The values were obtained from the
> Compact Flash specification Rev 4.1.
>
Note that I wasn't telling you to drop t4, just to correct its value
for SWDMA modes.
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
>
NAK, patch broken.
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 5e2eb74..1be2dde 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -2953,33 +2953,33 @@ int sata_set_spd(struct ata_link *link)
> */
>
> static const struct ata_timing ata_timing[] = {
> -/* { XFER_PIO_SLOW, 120, 290, 240, 960, 290, 240, 960, 0 }, */
> - { XFER_PIO_0, 70, 290, 240, 600, 165, 150, 600, 0 },
> - { XFER_PIO_1, 50, 290, 93, 383, 125, 100, 383, 0 },
> - { XFER_PIO_2, 30, 290, 40, 330, 100, 90, 240, 0 },
> - { XFER_PIO_3, 30, 80, 70, 180, 80, 70, 180, 0 },
> - { XFER_PIO_4, 25, 70, 25, 120, 70, 25, 120, 0 },
> - { XFER_PIO_5, 15, 65, 25, 100, 65, 25, 100, 0 },
> - { XFER_PIO_6, 10, 55, 20, 80, 55, 20, 80, 0 },
> -
> - { XFER_SW_DMA_0, 120, 0, 0, 0, 480, 480, 960, 0 },
> - { XFER_SW_DMA_1, 90, 0, 0, 0, 240, 240, 480, 0 },
> - { XFER_SW_DMA_2, 60, 0, 0, 0, 120, 120, 240, 0 },
> -
> - { XFER_MW_DMA_0, 60, 0, 0, 0, 215, 215, 480, 0 },
> - { XFER_MW_DMA_1, 45, 0, 0, 0, 80, 50, 150, 0 },
> - { XFER_MW_DMA_2, 25, 0, 0, 0, 70, 25, 120, 0 },
> - { XFER_MW_DMA_3, 25, 0, 0, 0, 65, 25, 100, 0 },
> - { XFER_MW_DMA_4, 25, 0, 0, 0, 55, 20, 80, 0 },
> -
> -/* { XFER_UDMA_SLOW, 0, 0, 0, 0, 0, 0, 0, 150 }, */
> - { XFER_UDMA_0, 0, 0, 0, 0, 0, 0, 0, 120 },
> - { XFER_UDMA_1, 0, 0, 0, 0, 0, 0, 0, 80 },
> - { XFER_UDMA_2, 0, 0, 0, 0, 0, 0, 0, 60 },
> - { XFER_UDMA_3, 0, 0, 0, 0, 0, 0, 0, 45 },
> - { XFER_UDMA_4, 0, 0, 0, 0, 0, 0, 0, 30 },
> - { XFER_UDMA_5, 0, 0, 0, 0, 0, 0, 0, 20 },
> - { XFER_UDMA_6, 0, 0, 0, 0, 0, 0, 0, 15 },
> +/* { XFER_PIO_SLOW, 120, 290, 240, 960, 290, 240, 0, 960, 0 }, */
> + { XFER_PIO_0, 70, 290, 240, 600, 165, 150, 0, 600, 0 },
> + { XFER_PIO_1, 50, 290, 93, 383, 125, 100, 0, 383, 0 },
> + { XFER_PIO_2, 30, 290, 40, 330, 100, 90, 0, 240, 0 },
> + { XFER_PIO_3, 30, 80, 70, 180, 80, 70, 0, 180, 0 },
> + { XFER_PIO_4, 25, 70, 25, 120, 70, 25, 0, 120, 0 },
> + { XFER_PIO_5, 15, 65, 25, 100, 65, 25, 0, 100, 0 },
> + { XFER_PIO_6, 10, 55, 20, 80, 55, 20, 0, 80, 0 },
> +
> + { XFER_SW_DMA_0, 120, 0, 0, 0, 480, 480, 50, 960, 0 },
> + { XFER_SW_DMA_1, 90, 0, 0, 0, 240, 240, 30, 480, 0 },
> + { XFER_SW_DMA_2, 60, 0, 0, 0, 120, 120, 20, 240, 0 },
> +
> + { XFER_MW_DMA_0, 60, 0, 0, 0, 215, 215, 20, 480, 0 },
> + { XFER_MW_DMA_1, 45, 0, 0, 0, 80, 50, 5, 150, 0 },
> + { XFER_MW_DMA_2, 25, 0, 0, 0, 70, 25, 5, 120, 0 },
> + { XFER_MW_DMA_3, 25, 0, 0, 0, 65, 25, 5, 100, 0 },
> + { XFER_MW_DMA_4, 25, 0, 0, 0, 55, 20, 5, 80, 0 },
> +
> +/* { XFER_UDMA_SLOW, 0, 0, 0, 0, 0, 0, 0, 0, 150 }, */
> + { XFER_UDMA_0, 0, 0, 0, 0, 0, 0, 0, 0, 120 },
> + { XFER_UDMA_1, 0, 0, 0, 0, 0, 0, 0, 0, 80 },
> + { XFER_UDMA_2, 0, 0, 0, 0, 0, 0, 0, 0, 60 },
> + { XFER_UDMA_3, 0, 0, 0, 0, 0, 0, 0, 0, 45 },
> + { XFER_UDMA_4, 0, 0, 0, 0, 0, 0, 0, 0, 30 },
> + { XFER_UDMA_5, 0, 0, 0, 0, 0, 0, 0, 0, 20 },
> + { XFER_UDMA_6, 0, 0, 0, 0, 0, 0, 0, 0, 15 },
>
> { 0xFF }
> };
>
[...]
> @@ -864,6 +866,8 @@ struct ata_timing {
> unsigned short cyc8b; /* t0 for 8-bit I/O */
> unsigned short active; /* t2 or tD */
> unsigned short recover; /* t2i or tK */
> + unsigned short write_hold; /* t4 */
> + unsigned short dmack_hold; /* tj */
> unsigned short cycle; /* t0 */
> unsigned short udma; /* t2CYCTYP/2 */
> };
>
This is broken. You're still adding 2 fields but initializer doesný
much that.
WBR, Sergei
next prev parent reply other threads:[~2008-12-10 23:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 23:37 [PATCH 0/3] libata: Cavium OCTEON SOC Compact Flash driver (v5) David Daney
2008-12-10 23:39 ` [PATCH 1/3] libata: Add another column to the ata_timing table David Daney
2008-12-10 23:52 ` Sergei Shtylyov [this message]
2008-12-11 1:50 ` David Daney
2008-12-11 2:11 ` David Daney
2008-12-10 23:39 ` [PATCH 2/3] libata: Add special ata_pio_need_iordy() handling for Compact Flash David Daney
2008-12-10 23:39 ` [PATCH 3/3] libata: New driver for OCTEON SOC Compact Flash interface (v5) David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49405640.4020205@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=ddaney@caviumnetworks.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).