Re: [PATCH] libata: blacklist NCQ on OCZ CORE 2 SSD (resend)

[Tejun Heo <tj@kernel.org>]

Hello,

Lubomír Bulej wrote:
> The patchlet below blacklists NCQ on OCZ CORE v2 SSD drive(s). Even
> though the drive advertises NCQ support with queue depth 1, it responds
> with all-zeroes FIS to NCQ commands which triggers ata error handling
> several times before the kernel decides to disable NCQ on the drive.
> 
> signed-off-by: Lubomir Bulej <lubomir.bulej@dsrg.mff.cuni.cz>

Please capitalize the leading s and add --- separator between
description and the patch body.

> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 5e2eb74..ba38eb8 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4048,6 +4048,7 @@ static const struct ata_blacklist_entry
> ata_device_blacklist [] = {
>      { "Maxtor 7V300F0",    "VA111630",    ATA_HORKAGE_NONCQ },
>      { "ST380817AS",        "3.42",        ATA_HORKAGE_NONCQ },
>      { "ST3160023AS",    "3.42",        ATA_HORKAGE_NONCQ },
> +    { "OCZ CORE_SSD",    "02.10104",    ATA_HORKAGE_NONCQ },
> 
>      /* Seagate NCQ + FLUSH CACHE firmware bug */
>      { "ST31500341AS",    "9JU138",    ATA_HORKAGE_NONCQ |

Other than that,

Acked-by: Tejun Heo <tj@kernel.org>

-- 
tejun