* [PATCH] libata: blacklist NCQ on OCZ CORE 2 SSD (resend)
@ 2008-12-22 10:35 Lubomír Bulej
2008-12-29 8:39 ` Tejun Heo
2008-12-29 12:41 ` Jeff Garzik
0 siblings, 2 replies; 5+ messages in thread
From: Lubomír Bulej @ 2008-12-22 10:35 UTC (permalink / raw)
To: jgarzik; +Cc: linux-ide
The patchlet below blacklists NCQ on OCZ CORE v2 SSD drive(s). Even though the
drive advertises NCQ support with queue depth 1, it responds with all-zeroes
FIS to NCQ commands which triggers ata error handling several times before the
kernel decides to disable NCQ on the drive.
signed-off-by: Lubomir Bulej <lubomir.bulej@dsrg.mff.cuni.cz>
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 5e2eb74..ba38eb8 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4048,6 +4048,7 @@ static const struct ata_blacklist_entry
ata_device_blacklist [] = {
{ "Maxtor 7V300F0", "VA111630", ATA_HORKAGE_NONCQ },
{ "ST380817AS", "3.42", ATA_HORKAGE_NONCQ },
{ "ST3160023AS", "3.42", ATA_HORKAGE_NONCQ },
+ { "OCZ CORE_SSD", "02.10104", ATA_HORKAGE_NONCQ },
/* Seagate NCQ + FLUSH CACHE firmware bug */
{ "ST31500341AS", "9JU138", ATA_HORKAGE_NONCQ |
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] libata: blacklist NCQ on OCZ CORE 2 SSD (resend)
2008-12-22 10:35 [PATCH] libata: blacklist NCQ on OCZ CORE 2 SSD (resend) Lubomír Bulej
@ 2008-12-29 8:39 ` Tejun Heo
2008-12-29 9:34 ` Sergei Shtylyov
2008-12-29 12:41 ` Jeff Garzik
1 sibling, 1 reply; 5+ messages in thread
From: Tejun Heo @ 2008-12-29 8:39 UTC (permalink / raw)
To: Lubomír Bulej; +Cc: jgarzik, linux-ide
Hello,
Lubomír Bulej wrote:
> The patchlet below blacklists NCQ on OCZ CORE v2 SSD drive(s). Even
> though the drive advertises NCQ support with queue depth 1, it responds
> with all-zeroes FIS to NCQ commands which triggers ata error handling
> several times before the kernel decides to disable NCQ on the drive.
>
> signed-off-by: Lubomir Bulej <lubomir.bulej@dsrg.mff.cuni.cz>
Please capitalize the leading s and add --- separator between
description and the patch body.
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 5e2eb74..ba38eb8 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4048,6 +4048,7 @@ static const struct ata_blacklist_entry
> ata_device_blacklist [] = {
> { "Maxtor 7V300F0", "VA111630", ATA_HORKAGE_NONCQ },
> { "ST380817AS", "3.42", ATA_HORKAGE_NONCQ },
> { "ST3160023AS", "3.42", ATA_HORKAGE_NONCQ },
> + { "OCZ CORE_SSD", "02.10104", ATA_HORKAGE_NONCQ },
>
> /* Seagate NCQ + FLUSH CACHE firmware bug */
> { "ST31500341AS", "9JU138", ATA_HORKAGE_NONCQ |
Other than that,
Acked-by: Tejun Heo <tj@kernel.org>
--
tejun
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libata: blacklist NCQ on OCZ CORE 2 SSD (resend)
2008-12-29 8:39 ` Tejun Heo
@ 2008-12-29 9:34 ` Sergei Shtylyov
2008-12-30 0:35 ` Tejun Heo
0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2008-12-29 9:34 UTC (permalink / raw)
To: Tejun Heo; +Cc: Lubomír Bulej, jgarzik, linux-ide
Hello.
Tejun Heo wrote:
>> The patchlet below blacklists NCQ on OCZ CORE v2 SSD drive(s). Even
>> though the drive advertises NCQ support with queue depth 1, it responds
>> with all-zeroes FIS to NCQ commands which triggers ata error handling
>> several times before the kernel decides to disable NCQ on the drive.
>>
>> signed-off-by: Lubomir Bulej <lubomir.bulej@dsrg.mff.cuni.cz>
>>
>
> Please capitalize the leading s and add --- separator between
> description and the patch body.
>
Why Lubomir needs to add --- if there's no diffstat or comments? :-O
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libata: blacklist NCQ on OCZ CORE 2 SSD (resend)
2008-12-22 10:35 [PATCH] libata: blacklist NCQ on OCZ CORE 2 SSD (resend) Lubomír Bulej
2008-12-29 8:39 ` Tejun Heo
@ 2008-12-29 12:41 ` Jeff Garzik
1 sibling, 0 replies; 5+ messages in thread
From: Jeff Garzik @ 2008-12-29 12:41 UTC (permalink / raw)
To: Lubomír Bulej; +Cc: linux-ide
Lubomír Bulej wrote:
>
> The patchlet below blacklists NCQ on OCZ CORE v2 SSD drive(s). Even
> though the drive advertises NCQ support with queue depth 1, it responds
> with all-zeroes FIS to NCQ commands which triggers ata error handling
> several times before the kernel decides to disable NCQ on the drive.
>
>
> signed-off-by: Lubomir Bulej <lubomir.bulej@dsrg.mff.cuni.cz>
>
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 5e2eb74..ba38eb8 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4048,6 +4048,7 @@ static const struct ata_blacklist_entry
> ata_device_blacklist [] = {
> { "Maxtor 7V300F0", "VA111630", ATA_HORKAGE_NONCQ },
> { "ST380817AS", "3.42", ATA_HORKAGE_NONCQ },
> { "ST3160023AS", "3.42", ATA_HORKAGE_NONCQ },
> + { "OCZ CORE_SSD", "02.10104", ATA_HORKAGE_NONCQ },
applied (manually)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libata: blacklist NCQ on OCZ CORE 2 SSD (resend)
2008-12-29 9:34 ` Sergei Shtylyov
@ 2008-12-30 0:35 ` Tejun Heo
0 siblings, 0 replies; 5+ messages in thread
From: Tejun Heo @ 2008-12-30 0:35 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Lubomír Bulej, jgarzik, linux-ide
Sergei Shtylyov wrote:
> Hello.
>
> Tejun Heo wrote:
>
>>> The patchlet below blacklists NCQ on OCZ CORE v2 SSD drive(s). Even
>>> though the drive advertises NCQ support with queue depth 1, it responds
>>> with all-zeroes FIS to NCQ commands which triggers ata error handling
>>> several times before the kernel decides to disable NCQ on the drive.
>>>
>>> signed-off-by: Lubomir Bulej <lubomir.bulej@dsrg.mff.cuni.cz>
>>>
>>
>> Please capitalize the leading s and add --- separator between
>> description and the patch body.
>
> Why Lubomir needs to add --- if there's no diffstat or comments? :-
Hmm... now come to think of it, you're right. I guess I'm now just
too accustomed to seeing it.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-12-30 0:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-22 10:35 [PATCH] libata: blacklist NCQ on OCZ CORE 2 SSD (resend) Lubomír Bulej
2008-12-29 8:39 ` Tejun Heo
2008-12-29 9:34 ` Sergei Shtylyov
2008-12-30 0:35 ` Tejun Heo
2008-12-29 12:41 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).