Re: [PATCH] ide: can't use SSD/non-rotational queue flag for all CFA devices

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=windows-1252; format=flowed, Size: 1063 bytes --]

Hello.

Bartlomiej Zolnierkiewicz wrote:

> Some rotating disks also present themselves as CFA devices.
>
> Reported-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>   

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

> Index: b/drivers/ide/ide-disk.c
> ===================================================================
> --- a/drivers/ide/ide-disk.c
> +++ b/drivers/ide/ide-disk.c
> @@ -633,7 +633,7 @@ static void ide_disk_setup(ide_drive_t *
>  	printk(KERN_INFO "%s: max request size: %dKiB\n", drive->name,
>  		q->max_sectors / 2);
>  
> -	if (ata_id_is_ssd(id) || ata_id_is_cfa(id))
> +	if (ata_id_is_ssd(id))
>  		queue_flag_set_unlocked(QUEUE_FLAG_NONROT, q);
>  
>  	/* calculate drive capacity, and select LBA if possible */
> N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·¥Š{±‰×¢žØ^n‡r¡ö¦zË\x1aëh™¨è­Ú&¢ø\x1e®G«éh®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿïêäz¹Þ–Šàþf£¢·hšˆ§~ˆmml==

Hm, why your Kmail base64-encodes plain English messages and adds this 
kind of binary crap?

MBR, Sergei